Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

Add Skyblocker Dark Mode

Open aricloverEXTRA opened this issue 1 month ago • 3 comments

Adds in Dark Mode textures for the mod Skyblocker (1.21.9/1.21.10 & 1.21.8-backport).

This pull request introduces Dark Mode GUI textures for Skyblocker,

This PR is in draft for now, since I haven’t added the code to toggle these Dark Mode assets yet. (edit: couldn’t make it toggleable, found out it used vanilla Minecraft textures in parts of the Skyblocker mod)

These assets are also from the following:

  1. https://github.com/aricloverEXTRA/Default-Dark-Mode-Expansion/tree/1.21/assets/skyblocker
  2. https://github.com/nebuIr/Default-Dark-Mode/pull/201

Dark Mode GUI example

2c959826ed1e0f8cfff3cfdbb1102c06e163b4f2

aricloverEXTRA avatar Nov 10 '25 05:11 aricloverEXTRA

2025-11-11_22 19 36_edited

Pull Request Update: it's almost complete, it's added as a built-in resource pack for Skyblocker 1.21.8 & 1.21.9/.10. All I need to do is add the important textures into it! (2025-11-13: Finished, feel free to change anything in the pr.)

aricloverEXTRA avatar Nov 12 '25 04:11 aricloverEXTRA

Those are pretty nice. I'm not sure if we want to add this since https://modrinth.com/resourcepack/skyblock-dark-ui exists and this affects vanilla assets unrelated to skyblocker (like the hotbar). Thoughts from the other devs?

viciscat avatar Nov 15 '25 20:11 viciscat

Those are pretty nice. I'm not sure if we want to add this since https://modrinth.com/resourcepack/skyblock-dark-ui exists and this affects vanilla assets unrelated to skyblocker (like the hotbar). Thoughts from the other devs?

There was a Skyblocker maintainer named kevinthegreat1 that said it was a nice addition. The comment can be found here. https://github.com/nebuIr/Default-Dark-Mode/pull/201#issuecomment-3005751972

But it’s up to y’all to determine if it should be merged or not. lmk if something happens!

aricloverEXTRA avatar Nov 16 '25 00:11 aricloverEXTRA

I didn't know https://modrinth.com/resourcepack/skyblock-dark-ui existed. I think this would make more sense there or just added here https://github.com/aricloverEXTRA/Default-Dark-Mode-Expansion. Since these two exist I don't think we need to add it into skyblocker.

kevinthegreat1 avatar Nov 20 '25 01:11 kevinthegreat1

Yeah, guessing this pull request will be closed now, it was an alright addition but with Skyblocker Dark UI & Default Dark Mode: Expansion having dark mode versions, it does make the pull request useless. Have a good day devs.

aricloverEXTRA avatar Nov 20 '25 03:11 aricloverEXTRA