Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

Wardrobe Helper Options, and Optional third argument for config commands.

Open Ashley-Cause opened this issue 10 months ago • 3 comments

Ashley-Cause avatar Feb 19 '25 05:02 Ashley-Cause

Apologies for the many commits, still figuring out how git works.

Added an option to display the keybind to select a wardrobe slot, instead of the hotbar number, for anyone who (like me) doesn't have their hotbar slots bound only to number keys.

Added an optional third argument to the /skyblocker (config/option) commands, to open a specific category/tab in the config. E.g. /Skyblocker config crimson opens the tag for the Crimson Isle location.

Ashley-Cause avatar Feb 19 '25 11:02 Ashley-Cause

Thanks for your pr. There seem to be two changes in here that should be split up. Since this pr is on your main branch, you should create two new branches, one for your wardrobe helper changes and one for your config command changes. You can use cherry pick to copy over the commits or you can manually make the changes. After that, you can open two new prs and close this one.

kevinthegreat1 avatar Feb 28 '25 03:02 kevinthegreat1

Also, there's no need for the option to show keybinds. Just show keybinds by default.

For command suggestions, don't hardcode the tab title values. Also, don't match the tab title by text, get the translation key at least.

kevinthegreat1 avatar Feb 28 '25 04:02 kevinthegreat1