Skyblocker icon indicating copy to clipboard operation
Skyblocker copied to clipboard

Museum HUD

Open 7azeemm opened this issue 10 months ago • 1 comments

Same code from #1064

7azeemm avatar Feb 09 '25 20:02 7azeemm

I believe this pr has problems under certain screen sizes and gui scales, thus this is not being reviewed.

kevinthegreat1 avatar Feb 20 '25 19:02 kevinthegreat1

everything should work, but there is an issue related to craft cost calculations or specificly the items recipes, there are some items in the neu repo contains stranded mode recipes, like spirit mask, wither artifact, ender artifact and many more https://wiki.hypixel.net/Stranded#Emeralds_for_Item_Trades_

but i couldn't find a way to bypass these kind of recipes in NEUItem obj https://github.com/NotEnoughUpdates/NotEnoughUpdates-REPO/pull/1912

7azeemm avatar Jul 16 '25 18:07 7azeemm

Similarly with some other PRs, this won't compile on 1.21.8 but the fixes should be pretty trivial since this is screen stuff: RenderLayer::getGuiTextured -> RenderPipelines.GUI_TEXTURED and giving rendered text a proper alpha.

AzureAaron avatar Jul 31 '25 05:07 AzureAaron

This will also need an REI Exclusion Zone. You can do something like this in SkyblockerREIClientPlugin#registerExclusionZones

zones.register(GenericContainerScreen.class, containerScreen -> {
	if (!SkyblockerConfigManager.get().uiAndVisuals.museumOverlay || !containerScreen.getTitle().getString().contains("Museum")) return List.of();
	HandledScreenAccessor accessor = (HandledScreenAccessor) containerScreen;
	return List.of(new Rectangle(accessor.getX() + accessor.getBackgroundWidth() + 4, accessor.getY(), MuseumManager.BACKGROUND_WIDTH, MuseumManager.BACKGROUND_HEIGHT));
});

Alex33856 avatar Aug 01 '25 21:08 Alex33856