SkyTube icon indicating copy to clipboard operation
SkyTube copied to clipboard

Background playback

Open avently opened this issue 7 years ago • 18 comments

This issue about https://github.com/ram-on/SkyTube/issues/6 You didn't answer to me so i created new issue. I added background playback to SkyTube from NewPipe. Most of the code i got from NewPipe and adapted it to SkyTube "reality". I'm not a Java programmer so expect bad practics in code. That's why i'm posting it here as a patch. You can try it and if you'll like it you can add it to your repo. It is not a 100% good solution but it works for me like i want it to work. Hope you'll find time and make this solution better. P.S. Thanks goes to NewPipe devs.

cd SkyTube git apply "backgroundplayback.txt location" backgroundplayback.txt

avently avatar Aug 23 '17 08:08 avently

Hi @avently thanks for your input. i'll look into it.

ram-on avatar Aug 23 '17 20:08 ram-on

@ram-on is doing nothing with this issue so, guys, feel free to use my fork if you want background playback and swipe controls in SkyTube https://github.com/avently/skytube

avently avatar Nov 02 '17 18:11 avently

@avently can you update your fork to use the latest https://github.com/ram-on/extractor.git ? I'd like to try it out after that.

ram-on avatar Nov 02 '17 21:11 ram-on

@ram-on done

avently avatar Nov 02 '17 22:11 avently

@avently do you publish an .apk for your fork version?

strk avatar Feb 06 '18 09:02 strk

@strk no. It doesn't have new features from original app because it is a little bit outdated. Maybe in the future background playback will be here too

avently avatar Feb 06 '18 09:02 avently

I'd really like to see basic support background playback, even if it doesn't have notification controls to begin with. I'm using NewPipe in the meantime.

rmenessec avatar Feb 13 '18 19:02 rmenessec

Hi, The last time I tried using the New Pipe application, it wouldn't allow me to play videos in the background either. As I remember, previously when I had a different version of the app installed, it did in fact allow background playing of videos, so I uninstalled the app and tried a different application ( Sky Tube ), now I'm having the same issue of playing videos in the background with it. David

Davy49 avatar Jul 08 '18 14:07 Davy49

Background play is currently partially supported. If the app is minimized, the video will still continue playing.

ram-on avatar Sep 30 '18 14:09 ram-on

@ram-on in background video stream is used, right? I think video stream should be changed to audio only stream because of the video vs audio size in MBs.

Also I noticed that bottom navigation is not show up in new versions while video is playing. So its impossible to view virtual buttons (back, home, etc). It's not a big problem so new issue is not needed

avently avatar Sep 30 '18 17:09 avently

@avently To view the bottom navigation bar, just swipe from the very top (to bottom).

ram-on avatar Sep 30 '18 20:09 ram-on

@ram-on its working bad. Because swipe from bottom changes video position while controls are visible or shows a video description. Its ok to hide virtual buttons while video controls are hidden but its not ok to hide them while controls are visible

avently avatar Sep 30 '18 21:09 avently

@avently You need to swipe from the top (i.e. the location where time/date is normally displayed) downwards -- refer to https://i.imgur.com/N0Tlv1B.png

ram-on avatar Oct 01 '18 17:10 ram-on

@ram-on yes, I know about that "workaround". So you think your app should work like this?

avently avatar Oct 01 '18 17:10 avently

@avently That's how it is intended to be.

ram-on avatar Oct 01 '18 19:10 ram-on

it'd be great if a notification is shown when video is playing in the background

aspieln3r avatar Apr 22 '20 04:04 aspieln3r

Hi, Thanks so much for the updated information ! David

Davy49 avatar Apr 22 '20 10:04 Davy49

So this can be closed now?

hamishmb avatar Aug 02 '22 13:08 hamishmb