Jasmin Savard

Results 473 comments of Jasmin Savard

Ok, this breaks because the ISlugService is not registered before doing AddAntiForgery(). Also, probably need to be registered like the ShellSettings are.

That's what I did in the next commit. There is still an issue with registering the service at the right place. I tried some places without success. Will take a...

I tried in the `AddDefaultServices()` without success. Maybe it was not a singleton though. I will try again.

Thanks @jtkech it works now as a singleton. I tested the Liquid filter on a Liquid page and it works so far.

Removing the "breaking change" label. It will only break modules that were using the SlugService in the OrchardCore.Liquid module. Marked the class as obsolete for now.

Ok, now the SlugService is registered only as an Application level singleton and it works for all OC modules. Removed the OrchardCore.Autoroute.Abstraction project. Moved the ISlugService to OrchardCore.Abstractions. I think...

Okay waiting on @sebastienros approval on this one.

2 approvals. I'm leaving someone else to merge this one. I fixed the remaining conflicts.

Oops, don't merge yet. Unit tests failing, that's a new one.