Jasmin Savard
Jasmin Savard
We need unit test at least for Lucene. Then it will be a copy for the other 2 but more complex as it will require an external service to run.
@hyzx86 Will you do the Unit Tests? I created feature enhancement ticket here : https://github.com/OrchardCMS/OrchardCore/issues/15601 @piedone I'm tempted to merge it into dev so that it is not blocking for...
@hyzx86 Not forgetting you, will try to find time to review this week.
@coderabbitai review 🐰 🐇 🐰 🐇 🐰 🐇 🐰 🐇 🐰 🐇 🐰 🐇 🐰 🐇 🐰 🐇
I believe it still needs proper unit tests. If we want to merge then we need to at least create a task/ticket/issue about Lucene Unit Tests.
Ok, so no merge untill we have proper unit tests just like we said before.
You can always still update the correlationId by using different methods as mentioned by @hyzx86 and J-T. Maybe it can potentially break someone's workflow but that's how it is when...
Yeah, maybe instead of setting it from server side we could have a script that would affect it. That would be non-breaking.
Waiting on @hyzx86 to know if he implemented what I suggested. If it is done then we need to review/test that code again to make sure it is fine. It...
Yeah, he seems to have added the method. I'd say, let's merge it.