Jasmin Savard comments

Results 473 comments of


                                            Jasmin Savard

Add DisplayAsync() overloads to render when a given feature is enabled

The only concern I have is that it makes that DisplayAsync call a little more expensive. Should we be concerned?

Keep file name of attached media files

Awesome we have a new contributor 🐰

Indexing exclude

Here it is only for the FullTextIndex though.

When a user create a new role, redirect the use to the edit page instead of index

Create = Create the role and go back to the list of roles page Create and Continue = Create the role and go to that role edit page Save =...

Markdown rich editor corrupts Arabic text in OC 1.4

Have you tried directly with the same text and the markdown editor on their website demo?

Markdown rich editor corrupts Arabic text in OC 1.4

I see the text is reversed in the editor. That would be a styling issue.

Markdown rich editor corrupts Arabic text in OC 1.4

I just found this repository which probably indicates that EasyMDE has issues with RTL. https://github.com/imAbdelhadi/easymde-rtl

Markdown rich editor corrupts Arabic text in OC 1.4

@dodyg I think we could bundle the RTL version in OC and switch to it based on CultureInfo RTL. Feel free to open a pull request.

Markdown rich editor corrupts Arabic text in OC 1.4

Maybe a BS 5 upgrade regression. If this can be fixed by changing only styles then it will be better. I didn't find where it is reversing the text.

Markdown rich editor corrupts Arabic text in OC 1.4

Have you tried removing only the `/*rtl:ignore*/` comment? Also, make sure you test with different RTL cultures afterward because it seems like it works for other people.