tinybutstrong icon indicating copy to clipboard operation
tinybutstrong copied to clipboard

Tests update

Open roxblnfk opened this issue 7 years ago • 9 comments

simpleTest 1.1 added into composer.json

Old simpleTest was not deleted (for compatibility tests with php <5.4)

The results of running tests without plugins on different php versions below: tests

Just run testunit/index.php on php 5 or php 7

Not tested on php <5.3

roxblnfk avatar Jan 19 '18 12:01 roxblnfk

Support for console mode image

roxblnfk avatar Jan 20 '18 10:01 roxblnfk

Please rebase your branch on master to avoid any merge commits and then force push your changes

simonschaufi avatar Jan 20 '18 11:01 simonschaufi

Please rebase your branch on master to avoid any merge commits and then force push your changes

Can i do it from web interface?

roxblnfk avatar Jan 20 '18 11:01 roxblnfk

Can i do it from web interface?

unfortunatelly not. If you collaborate with others on one pull request you should avoid that as it rewrites your commits. Do that only if you are the only one working on that pull request. Thats why github doesn't support that on the platform.

simonschaufi avatar Jan 20 '18 11:01 simonschaufi

composer test is now available

roxblnfk avatar Feb 01 '18 10:02 roxblnfk

I suggest to simply delete the « testunit » and « benches » from this repository. Those are quite old tools now. What do you think ?

Skrol29 avatar Feb 13 '18 23:02 Skrol29

would you suggest switchting to phpunit? how easy is it to move to phpunit?

simonschaufi avatar Feb 13 '18 23:02 simonschaufi

The modern PHPUnit requires php >= 7.1

In this Pull Request i suggest only that you update SimpleTest without losing compatibility For php <5.4 will be used old SimpleTest For php >=5.4 will be used last SimpleTest

When the project will depend on php >=7 then it will be meaningful to rewrite the tests for PHPUnit

roxblnfk avatar Feb 14 '18 08:02 roxblnfk

> composer update
> composer test

image

roxblnfk avatar Apr 29 '19 08:04 roxblnfk