tinybutstrong icon indicating copy to clipboard operation
tinybutstrong copied to clipboard

Published 20 hours ago • verified publisher icon Skrol29

Reformat code to PSR2 and use short array syntax

Open simonschaufi opened this issue 7 years ago • 5 comments

No code changes, just reformating and replacing array() with []

simonschaufi avatar Jan 18 '18 23:01 simonschaufi

Square brackets require a php version >=5.4

roxblnfk avatar Jan 19 '18 09:01 roxblnfk

Yes I know but these old php versions are not supported anymore.

simonschaufi avatar Jan 19 '18 10:01 simonschaufi

The problem is PHP 5.3 is 20% used of the PHP 5 versions, just quite as much as PHP 5.4 PHP 7 is 12% of all PHP versions. https://w3techs.com/technologies/history_details/pl-php/5

Skrol29 avatar Feb 13 '18 23:02 Skrol29

Well, one day, sooner or later you have to say: From now on I won't support totally outdated php versions any more (and php 5.3 is totally outdated). Officially supported is just php5.6 at the moment. Of course after merging this, the second or even the first version number should be raised up as it will break existing systems if they try to upgrade and still have 5.3 running. So imho a new major version should be released.

simonschaufi avatar Feb 13 '18 23:02 simonschaufi

@Skrol29 Are you still interested in this PR? I just found it again while browsing through my open PRs. Should I clean this up so it can be merged?

simonschaufi avatar Feb 06 '20 02:02 simonschaufi