SkriptLang
Fix lantern not working
Fix lantern not working. on place of lantern does not work, you had to use any lantern to fix that issue.
Does this not conflict with regular lanterns? Also, there are two instances of any lantern(so if you're making changes, you'll need to change both)
Agree with @APickledWalrus, seems like this will conflict with the normal (non-soul) lantern alias. There seems to be a different issue at play here if on place of lantern doesn't work.
As for this, Pickle...
Also, there are two instances of
any lantern
I assume you mean the ones in "nether update" and "nether update part 2"? If so, the 2nd one is overriding the first one to include the {waterloggable} overrides for lanterns from lines 670 and 671.
Does this not conflict with regular lanterns? Also, there are two instances of
any lantern(so if you're making changes, you'll need to change both)
Point out where it's defined twice.
It's defined here https://github.com/SkriptLang/skript-aliases/blob/fb9c3044e555667b4dc5558467608bd55fa32df0/decoration.sk#L404 and again here https://github.com/SkriptLang/skript-aliases/blob/fb9c3044e555667b4dc5558467608bd55fa32df0/decoration.sk#L670 due to some changes with the data the block supports
It's defined here
https://github.com/SkriptLang/skript-aliases/blob/fb9c3044e555667b4dc5558467608bd55fa32df0/decoration.sk#L404 and again here
https://github.com/SkriptLang/skript-aliases/blob/fb9c3044e555667b4dc5558467608bd55fa32df0/decoration.sk#L670 due to some changes with the data the block supports
It will redefine it
My main concern here is that this overrides the existing alias for just regular lanterns. There is then no good way to just give the user or check for a "normal" lantern early, and I do not feel that requiring normal lantern is an ideal approach.