ExprSkull - Breaking Change

[Absolutionism]

Problem

ExprEyeLocation and ExprSkull has a pattern confliction of head of ... which could lead to the retrieval of the wrong expression depending on the use case.

Solution

This PR fixes this confliction by removing the option of head in ExprSkull Thus allowing users to be able to retrieve the exact expression/return type they desire. Is a breaking change.

Testing Completed

N/A

Supporting Information

N/A

---

Completes: #7837 Related: none

[sovdeeth]

this seems a bit more breaking than is really necessary player's eyes works just fine without location Can I ask why you chose to change this expression instead of, for example, limiting the skull expression to just player's skull?

[Absolutionism]

this seems a bit more breaking than is really necessary player's eyes works just fine without location Can I ask why you chose to change this expression instead of, for example, limiting the skull expression to just player's skull?

Well the lack of discussion in the issue didn't really point towards changing ExprSkull as the only opinion that was made was to require location by @EquipableMC

[sovdeeth]

Gotcha Do you have any opinions on it? I personally would prefer having the skull expression changed instead, but I'm also pretty sure that would impact more users so it might be preferable to keep it as is

[Absolutionism]

Do you have any opinions on it?

I'm neutral, either or.

[Fusezion]

Being the one who made the issue I'll at least give my perspective. As I said on the issue either or I personally push towards ExprSkull more than ExprEyeLocation, but I also know I see head of player more than skull of player

[sovdeeth]

Moving this to dev/feature due to breaking changes

[cheeezburga]

I don't think I love making the location part here mandatory. Would rather see the change made to ExprSkull - even if it is more breaking right now, I think it's better in the long run.

[Absolutionism]

So the current count seems to be Change ExprEyeLocation - Equip (1) Change ExprSkull - Fusezion, Sovde, and Cheez (3)

So I'll change this PR to change ExprSkull

[EquipableMC]

So the current count seems to be Change ExprEyeLocation - Equip (1) Change ExprSkull - Fusezion, Sovde, and Cheez (3)

So I'll change this PR to change ExprSkull

I was also either or. It just made sense to me but I can also see why ExprSkull is in favor.