SkriptLang
Loudly Failing 🗣️ Part: Effects
Description
This PR implements SyntaxRuntimeErrorProducer on all relevant effects, with highlighting where possible and necessary, and generally cleans up/updates them to use modern conventions.
There were a few effects I left as is, as I thought they'd be overhauled sometime soon, or there was a significant recent PR changing them. Examples of these are: EffBan, EffVisualEffect, EffVehicle, etc.
I think the way these are implemented looks nice for the user, and displays relevant information, but opinions are more than welcome on this! I also think I changed standards half way through the PR, so I'll go back and update some of the first ones if there's no problems with the format.
Target Minecraft Versions: any Requirements: none Related Issues: none
Since you basically have almost all effects implementing SyntaxRuntimeErrorProducer, do you think it would be worth just making Effect.class implement it instead?
Do you think there might be a way to do the getnode stuff in a syntax superclass rather than in each one?
I was thinking this too, but I'm not entirely sure. This seems like kind of thing that @sovdeeth wouldve thought about while designing this system, so would love to hear his thoughts.
Short answer: no Long answer: https://discord.com/channels/135877399391764480/836220422223036467/1327037996318457927
@cheeezburga Just for clarity, Sovde was answering about my comment of implementing it straight into Effect.class and not about what you and Kenzie were referencing.