Skript icon indicating copy to clipboard operation
Skript copied to clipboard

On Click BlockData

Open Absolutionism opened this issue 1 year ago • 2 comments

Description

This PR aims to support blockdata for on click


Target Minecraft Versions: any Requirements: none Related Issues: #6305

Absolutionism avatar Oct 04 '24 18:10 Absolutionism

Just some small stuff, but you should also remove finals that are scattered throughout, and theres still code that can be updated (switch statements, etc.).

I could change to an enhanced switch, but I cant put both case PHYSICAL and default on the same line leading to two return falses Other than that, I dont really see anything else sticking out that might need to be updated, imo, but if you would like to point out some things I can take a look.

Absolutionism avatar Oct 05 '24 16:10 Absolutionism

I could change to an enhanced switch, but I cant put both case PHYSICAL and default on the same line leading to two return falses Other than that, I dont really see anything else sticking out that might need to be updated, imo, but if you would like to point out some things I can take a look.

I think an enhanced one would look a bit nicer, but up to you. I don't think there was anything else, but I wouldn't hate if you wanted to change the error messages a bit in init, as they seem a bit clunky and/or misleading at the moment.

cheeezburga avatar Oct 09 '24 20:10 cheeezburga