Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Make visual effects serializable

Open Romitou opened this issue 1 year ago • 1 comments

Description

Started by @TPGamesNL in PR #4123 (the commit has been cherry-picked and the author has been kept for credits), providing a serializer for VisualEffectType allows to serialize VisualEffect correctly. In fact, this should have been handled by simpleClassLoaders, where this specific class was originally registered.

However, the Yggdrasil#getSerializer method did not return a serializer: a SimpleClassResolver extends from ClassResolver and not from a YggdrasilSerializer like the others. A fix is therefore to directly register this serializer at the root of classResolvers.

https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/yggdrasil/Yggdrasil.java


Target Minecraft Versions: any Requirements: none Related Issues: #4196

Romitou avatar Sep 26 '24 21:09 Romitou