Skript icon indicating copy to clipboard operation
Skript copied to clipboard
verified publisher icon SkriptLang

PlayerExpCooldown

Open Absolutionism opened this issue 1 year ago • 4 comments

Description

This PR aims to add PlayerExpCooldownChangeEvent and correlating expression.

Target Minecraft Versions: any Requirements: none Related Issues: #5802

Absolutionism avatar Sep 13 '24 22:09 Absolutionism

and tests please :)

Efnilite avatar Sep 13 '24 22:09 Efnilite

Still would love to see tests for the expression!

How do you propose I do the tests for the expression?

Absolutionism avatar Sep 15 '24 07:09 Absolutionism

Still would love to see tests for the expression!

How do you propose I do the tests for the expression?

Something similar to this, https://github.com/Efnilite/Skript/blob/38d855925ad17b20923080155bc42d1704cad56a/src/test/skript/junit/-EvtPiglinBarter.sk, you just try all the change modes and see if it changed correctly

Efnilite avatar Sep 15 '24 09:09 Efnilite

So as expected, using the expressions on an EasyMock Player does not work and throws stack traces. Which I knew would happen from the get go and is why I didn't add it.

Absolutionism avatar Sep 16 '24 19:09 Absolutionism