SkriptLang
Adds Spark Support!
Description
This PR simply adds features from Spark into Skript!
Target Minecraft Versions: 1.19+ Requirements: Spark plugin Related Issues: none
I'm sure you have enough comments to work on already so I won't add anything to that.
I think this is a nice idea, but I am a little concerned by the 'weirdness' of Spark's actual statistics collection & implementation. It feels like the stats that can be provided are pretty limited and I'm not sure how much a user will be able to do with this information (aside from printing out exactly what they're given).
Do you think this might be better for an addon?
I don't think this should be done as an addon since spark is built into most server jars (other than spigot)
Changes to pay attention to:
there's now a msptstatistics classinfo with a parser for average, mean, max, min, maximum, minimum, and \d{1,2}.\d+(st|nd|rd|th) percentile
This makes using the mspt syntax much easier, but it could possible cause weird conflict in the future and allows odd behavior like set {_x} to average.
I don't think you should be resolving conflicts after you reply when it seems a discussion should be made. Rather than "I can't/won't do this" then resolve it.
I don't think you should be resolving conflicts after you reply when it seems a discussion should be made. Rather than "I can't/won't do this" then resolve it.
I only marked them as resolved as it works fine on it's own and with my almost a year of java experience, I only know so much and figured it was fine the way it was. I left some unresolved as it requires Sovde's comment as this PR was entirely recoded by Sovde and I don't really understand his thinking/thought process in some of this even when looking at the code over and over again. Edit: I have unmarked some that I found where a discussion where be made. I forgot to mention that, oops.
I am marking this PR as draft incase someone else wants to take this over and better improve the PR. Once that happens, I will close this PR. You can view the entire conversation here.
Update: I am marking this PR as closed. Someone can take it over or it can be done in a seperate addon. You can view the entire conversation here.