Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Changeable Max Stack Size for Items and Inventory

Open NotSoDelayed opened this issue 1 year ago • 4 comments

Description

This PR adds support of changeable max stack size of inventories and the recently introduced max stack size ItemMeta in Minecraft 1.20.5.

Javadocs:

  • (ItemMeta) https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/meta/ItemMeta.html#setMaxStackSize(java.lang.Integer)
  • (Inventory) https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/Inventory.html#setMaxStackSize(int)

Note

Using GitHub actions to test the attached test scripts due to Skript testing environment abruptly failing. My sincerely apologies for any bulk commits from fixing tests.


Target Minecraft Versions: Minecraft 1.20.5 (changeable itemstack max stack size) Requirements: Spigot 1.20.5 (changeable max stack size ItemMeta) Related Issues: #5020 (inventory)

NotSoDelayed avatar May 15 '24 03:05 NotSoDelayed

Should this PR also include changes to the is stackable condition to properly reflect this new stuff?

cheeezburga avatar May 19 '24 18:05 cheeezburga

Should this PR also include changes to the is stackable condition to properly reflect this new stuff?

The condition checks if the max stack size is more than 1, which to me it looks like it is fine as is, unless I’m missing something. image

NotSoDelayed avatar May 21 '24 01:05 NotSoDelayed

Should this PR also include changes to the is stackable condition to properly reflect this new stuff?

The condition checks if the max stack size is more than 1, which to me it looks like it is fine as is, unless I’m missing something. image

Ye I have no idea what I was thinking when I looked at the condition earlier, looks so fine. Probably a result of no sleep tbh, my bad.

cheeezburga avatar May 21 '24 21:05 cheeezburga

Java 17 ready!

NotSoDelayed avatar Sep 16 '24 08:09 NotSoDelayed