Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Support for LogLevel in EffLog

Open EquipableMC opened this issue 9 months ago • 11 comments

Description

Added ways to declare severity when logging


Target Minecraft Versions: any Requirements: none Related Issues: none

EquipableMC avatar May 08 '24 00:05 EquipableMC

adding breaking changes due to adding INFO to the output by default.

sovdeeth avatar May 08 '24 21:05 sovdeeth

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

EquipableMC avatar May 08 '24 21:05 EquipableMC

adding breaking changes due to adding INFO to the output by default.

Sorry but how does this apply a breaking change? Very confused there.

Fusezion avatar May 08 '24 21:05 Fusezion

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

Okay now I have image

EquipableMC avatar May 08 '24 21:05 EquipableMC

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

Okay now I have image

I'm mainly concerned about the other severities in console

sovdeeth avatar May 08 '24 21:05 sovdeeth

Also, have you actually tested this? I'd like to see a screenshot of the output.

I have not

Okay now I have image

I'm mainly concerned about the other severities in console

I don't know why exactly warning/severe has a tab

image

EquipableMC avatar May 08 '24 21:05 EquipableMC

alright so let's do an actual test equip

on load:
    log "info"
    log "warning" with severity of warning
    log "severe" with severity of severe

this should log on reload my guess is severe will not work but info and warning will

Fusezion avatar May 08 '24 21:05 Fusezion

alright so let's do an actual test equip

on load:
    log "info"
    log "warning" with severity of warning
    log "severe" with severity of severe

this should log on reload my guess is severe will not work but info and warning will

image

yeah you're right

EquipableMC avatar May 08 '24 21:05 EquipableMC

This is why I was talking about a RedirectingLogHandler in discord You'll need it for warning/error.

sovdeeth avatar May 08 '24 21:05 sovdeeth

adding breaking changes due to adding INFO to the output by default.

Sorry but how does this apply a breaking change? Very confused there.

@Fusezion file output would now have an INFO where there was none previously.

sovdeeth avatar May 09 '24 10:05 sovdeeth

alright so let's do an actual test equip

on load:

log "info"
log "warning" with severity of warning
log "severe" with severity of severe

this should log on reload my guess is severe will not work but info and warning will

image

yeah you're right

Okay so regarding this, this has been fixed.

EquipableMC avatar May 11 '24 01:05 EquipableMC