Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Some armour stand syntax

Open cheeezburga opened this issue 9 months ago • 3 comments

Description

Adds some armour stand syntax. So far, this PR includes a couple of effects and conditions for extremities (arms, base plate), behaviour (canTick, canMove) and properties (size, marker). Would love any feedback.

Probably won't do in this PR:

  • Disabled/locked slots
  • Poses
  • Rotations

Target Minecraft Versions: any (so far) Requirements: none Related Issues: #6597

cheeezburga avatar Apr 26 '24 15:04 cheeezburga

Just a note, the tick/move methods for ArmorStand are part of PaperAPI not Bukkit API, so you will have to do checks for that to prevent errors on Spigot

ShaneBeee avatar Apr 26 '24 17:04 ShaneBeee

Just a note, the tick/move methods for ArmorStand are part of PaperAPI not Bukkit API, so you will have to do checks for that to prevent errors on Spigot

Oh ty, I missed that when I was adding them. Thinking about moving them to their own separate class coz they feel kinda out of place in the Properties class imo (make %armor stands% move really doesnt get across what its doing ya know). Would make that check a bit easier to do as well.

cheeezburga avatar Apr 26 '24 22:04 cheeezburga

just some formatting A few edge case tests would also be good, eg put in a null variable, or a non-armor stand entity, etc.

You should also be using delete entity within {_e} tbh

Added some edge case tests (the two that were mentioned). Let me know if there are any more I should worry about, or if the ones that were added are done wrong.

cheeezburga avatar May 13 '24 19:05 cheeezburga