Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Fix InventoryItemMoveEvent Implementations (#5462)

Open NotSoDelayed opened this issue 2 years ago • 4 comments

Description

This PR fixes #5462 where event values were unknowingly removed before the merge, with additions to event-block support and JUnit test.


Target Minecraft Versions: any Requirements: none Related Issues: #5462, #6092

NotSoDelayed avatar Dec 14 '23 19:12 NotSoDelayed

tests 😍

Pikachu920 avatar Dec 14 '23 20:12 Pikachu920

Tests for this PR cannot be proceeded until #6261 and other issues related to delayed tests to be fixed in Skript's JUnit testing system.

NotSoDelayed avatar Dec 28 '23 20:12 NotSoDelayed

Tests for this PR cannot be proceeded until #6261 and other issues related to delayed tests to be fixed in Skript's JUnit testing system.

If the junit changes can't be made in time for 2.8, consider testing by just creating and calling a InventoryMoveEvent yourself.

sovdeeth avatar Dec 29 '23 02:12 sovdeeth

I'd like to have this in 2.8-pre1, @DelayedGaming, so would you be willing to either do (or let me do) the changes to the tests I suggested above as a stopgap until those JUnit fixes are done?

sovdeeth avatar Dec 30 '23 07:12 sovdeeth

As #6451 points a pattern improvement, I decided to apply it into this PR as both are on the same page.

NotSoDelayed avatar Feb 27 '24 02:02 NotSoDelayed