Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Allow people to use item name ids instead of item names

Open andriemc opened this issue 2 years ago • 13 comments

Suggestion

Allow us to also use diamond_sword instead of diamond sword in skripts

Why?

Some people might want this.

Other

No response

Agreement

  • [X] I have read the guidelines above and affirm I am following them with this suggestion.

andriemc avatar Oct 15 '22 06:10 andriemc

Is there any good reason for this suggestion? why can't users use item's english-like names? (Maybe provide a use case)

AyhamAl-Ali avatar Oct 16 '22 09:10 AyhamAl-Ali

Some admins that have never used Skript don't know how to type it in english style. They are famillar with the diamond_sword like style.

andriemc avatar Oct 16 '22 14:10 andriemc

They're using Skript, not Java enums, they wouldn't commonly type an extra character when space is easier and quicker.

TheLimeGlass avatar Oct 16 '22 15:10 TheLimeGlass

There are people who do it wrong, but i dont think its "worth the effort" or important and i guess it would look pretty ugly in the source code

iPlexy avatar Oct 16 '22 19:10 iPlexy

If they dont know how to type in english, they shouldnt use skript bro xD

iPlexy avatar Oct 16 '22 19:10 iPlexy

Ok.

andriemc avatar Oct 18 '22 12:10 andriemc

Keeping this open until we get more opinions from the team.

AyhamAl-Ali avatar Oct 18 '22 13:10 AyhamAl-Ali

I will also express my unnecessary opinion about this idea. If such a possibility is already introduced, then the best solution would be to get rid of the previous system of aliases. In general, this would be nice, except that all the Script code that was written earlier will be lost. But on the plus side, we get the opportunity to be much closer to the bukkit api. No need to develop aliases. The presence of the Material class. Even better would be the possibility, from one of the previously suggested ideas:

set {_} to DIRT[itemMeta/BlockData]

I personally think it is not advisable to have two naming systems at once. And if necessary, most people already use Skript-reflect

Lotzyprod avatar Oct 18 '22 14:10 Lotzyprod

There is a rework plan for Aliases which then we can allow minecraft material names such as minecraft:stone and diamond_sword.

There is also a related issue:

  • #2091

AyhamAl-Ali avatar Oct 18 '22 14:10 AyhamAl-Ali

There is a rework plan for Aliases which then we can allow minecraft material names such as minecraft:stone and diamond_sword.

There is also a related issue:

Can I have some explanation? Will the rework plan to replace the alias system, or just adding the ability to use naming conventions from the Material class?

Lotzyprod avatar Oct 18 '22 14:10 Lotzyprod

It's still not very clear how it will become but this is a discussion that was going and based on the outcomes the plan will be

  • #4164

AyhamAl-Ali avatar Oct 18 '22 14:10 AyhamAl-Ali

I fully support this, since we support it in BlockData ex: set target block to oak_stairs[] or set target block to minecraft:oak_stairs[]

Since these work, I say yes.

Its not just about the java enums, its also about MC commands, ex: /give ShaneBee diamond_sword

ShaneBeee avatar Dec 18 '22 01:12 ShaneBeee

The following methods should work:

give minecraft:diamond_sword to player

or:

give diamond_sword to player

or:

give diamond sword to player

andriemc avatar Dec 18 '22 08:12 andriemc