Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Published 20 hours ago • verified publisher icon SkriptLang

Don't save materials.json anymore

Open APickledWalrus opened this issue 2 years ago • 1 comments

Description

This PR stops Skript from saving materials.json. The values are just calculated each time during startup. I've also added in a check to delete the file as it's no longer used. I don't see what benefits saving it has - if someone has an idea, please share here!

I will open another PR at some point to remove the usage of these mappings on newer versions,

Target Minecraft Versions: 1.12 and below Requirements: N/A Related Issues:

  • https://github.com/SkriptLang/Skript/issues/4861

APickledWalrus avatar Sep 18 '22 00:09 APickledWalrus

Why not add a version tag to the file, and only delete and build if it's different than the current version.

TheLimeGlass avatar Sep 20 '22 17:09 TheLimeGlass

Closed as this will be integrated in https://github.com/SkriptLang/Skript/pull/4961

APickledWalrus avatar Oct 06 '22 21:10 APickledWalrus