Skript icon indicating copy to clipboard operation
Skript copied to clipboard

ExprJoinSplit config case sensitivity

Open UnderscoreTud opened this issue 2 years ago • 1 comments

Description

This PR makes the split expression use the config's case sensitivity option


Target Minecraft Versions: any Requirements: none Related Issues: https://github.com/SkriptLang/Skript/issues/4886

UnderscoreTud avatar Aug 28 '22 20:08 UnderscoreTud

I'm against supporting this config option. You can see my reasoning here: #4823

However, I do think it would be good to support case sensitivity through a syntax option. Like how EffReplace does it:

https://github.com/SkriptLang/Skript/blob/852d4e4b7803dcf724a7b4ef7c3f8ab1b766f9c4/src/main/java/ch/njol/skript/effects/EffReplace.java#L57-L60

It does have an option to enable case sensitivity, I believe removing the case sensitivity config option should be its own PR as there are other elements that use it for now, and removing the option in this element alone would result in inconsistency within the elements. Although I totally agree with you

UnderscoreTud avatar Aug 28 '22 22:08 UnderscoreTud