Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Lingering Potion (ThrownPotionData) entity data error.

Open TheLimeGlass opened this issue 3 years ago • 1 comments

Skript/Server Version

2.6.2 (with master of 2.6.3)
Tested on all versions from 1.13-1.19 only happens with 1.13.X

Bug Description

There is an error using the test case thrown potion entity data

Expected Behavior

Not error

Steps to Reproduce

Run the test test case thrown potion entity data on 1.13

Errors or Screenshots

[19:31:42 ERROR]: #!#! [Skript] Severe Error:
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! Skript is running with developer command-line options.
[19:31:42 ERROR]: #!#! If you are not a developer, consider disabling them.
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! Stack trace:
[19:31:42 ERROR]: #!#! java.lang.IllegalArgumentException: ItemStack must be a splash potion. This item stack was LINGERING_POTION.
[19:31:42 ERROR]: #!#!     at org.apache.commons.lang.Validate.isTrue(Validate.java:136)
[19:31:42 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_13_R2.entity.CraftSplashPotion.setItem(CraftSplashPotion.java:24)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.entity.ThrownPotionData.spawn(ThrownPotionData.java:116)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.entity.ThrownPotionData.spawn(ThrownPotionData.java:45)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.entity.EntityData.spawn(EntityData.java:417)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.sections.EffSecSpawn.walk(EffSecSpawn.java:160)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.lang.EffectSectionEffect.walk(EffectSectionEffect.java:44)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:89)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.lang.Trigger.execute(Trigger.java:56)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.SkriptEventHandler.check(SkriptEventHandler.java:142)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.SkriptEventHandler$PriorityListener.lambda$new$0(SkriptEventHandler.java:71)
[19:31:42 ERROR]: #!#!     at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80)
[19:31:42 ERROR]: #!#!     at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:66)
[19:31:42 ERROR]: #!#!     at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:520)
[19:31:42 ERROR]: #!#!     at ch.njol.skript.Skript$1.lambda$run$0(Skript.java:633)
[19:31:42 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftTask.run(CraftTask.java:84)
[19:31:42 ERROR]: #!#!     at org.bukkit.craftbukkit.v1_13_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:449)
[19:31:42 ERROR]: #!#!     at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1010)
[19:31:42 ERROR]: #!#!     at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439)
[19:31:42 ERROR]: #!#!     at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:940)
[19:31:42 ERROR]: #!#!     at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:837)
[19:31:42 ERROR]: #!#!     at java.base/java.lang.Thread.run(Thread.java:835)
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! Version Information:
[19:31:42 ERROR]: #!#!   Skript: 2.6.2 (custom version)
[19:31:42 ERROR]: #!#!     Flavor: selfbuilt-unknown
[19:31:42 ERROR]: #!#!     Date: unknown
[19:31:42 ERROR]: #!#!   Bukkit: 1.13.2-R0.1-SNAPSHOT
[19:31:42 ERROR]: #!#!   Minecraft: 1.13.2
[19:31:42 ERROR]: #!#!   Java: 12.0.2 (OpenJDK 64-Bit Server VM 12.0.2+10)
[19:31:42 ERROR]: #!#!   OS: Windows 10 amd64 10.0
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! Server platform: Paper
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! Current node: null
[19:31:42 ERROR]: #!#! Current item: spawn [[entitytype:thrown lingering potions of health]] at {_l} (as org.bukkit.Location)
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! Thread: Server thread
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! Language: english
[19:31:42 ERROR]: #!#! Link parse mode: DISABLED
[19:31:42 ERROR]: #!#!
[19:31:42 ERROR]: #!#! End of Error.

TheLimeGlass avatar Jul 12 '22 01:07 TheLimeGlass

In 1.13, spawning a lingering potion requires usage of LingeringPotion entity, versions about that have this class deprecated and allow you to use ThrownPotion instead.

Skript should register a LingeringPotionData only on 1.13, being pretty much a duplicate of ThrownPotionData except using LingeringPotion instead of ThrownPotion.

TPGamesNL avatar Jul 12 '22 08:07 TPGamesNL