Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Poland translation language

Open maxwhitepl opened this issue 2 years ago • 12 comments

Description

Full translation of the file along with comments


Target Minecraft Versions: any Requirements: Related Issues:

maxwhitepl avatar Jul 10 '22 16:07 maxwhitepl

Adding Shane as a reviewer as Shane did past languages.

TheLimeGlass avatar Jul 12 '22 09:07 TheLimeGlass

We'll mostly need reviews from Polish speaking people, don't think Shane qualifies for that

One thing I can say @Zabujca997 is that it's better to leave the comments (starting with #) in English

TPGamesNL avatar Jul 12 '22 10:07 TPGamesNL

@TPGamesNL I support this. I will improve it in a while thank you for your suggestions

@TheLimeGlass I'm happy to help translate.

maxwhitepl avatar Jul 12 '22 10:07 maxwhitepl

We'll mostly need reviews from Polish speaking people, don't think Shane qualifies for that

One thing I can say @Zabujca997 is that it's better to leave the comments (starting with #) in English

Shane as in making sure all the language components were handled.

TheLimeGlass avatar Jul 12 '22 11:07 TheLimeGlass

We have a closed PR #4544 which might be a good comparison.

Moderocky avatar Jul 12 '22 11:07 Moderocky

We have a closed PR #4544 which might be a good comparison.

Weird that it was closed. Maybe @Zabujca997 could check it out and implement what was stated.

TheLimeGlass avatar Jul 12 '22 11:07 TheLimeGlass

Shane as in making sure all the language components were handled.

Any team member can do that, you just need to compare the file to one of the existing languages (e.g. English) and check that all keys are included in this one.

TPGamesNL avatar Jul 12 '22 11:07 TPGamesNL

@TheLimeGlass @TPGamesNL @Nicofisi I corrected all errors, please check if everything is ok

maxwhitepl avatar Jul 12 '22 12:07 maxwhitepl

@Zabujca997 looks good 👍 one small thing: change the <nic> at the top back to <none> , this entry was just added to the language files so users can modify it more easily, but isn't supposed to actually be translated.

Checked, all entries are present

TPGamesNL avatar Jul 12 '22 12:07 TPGamesNL

@Zabujca997 looks good 👍 one small thing: change the <nic> at the top back to <none> , this entry was just added to the language files so users can modify it more easily, but isn't supposed to actually be translated.

Checked, all entries are present

Okay Thanks ❤

maxwhitepl avatar Jul 12 '22 12:07 maxwhitepl

We'll mostly need reviews from Polish speaking people, don't think Shane qualifies for that

you don't knooowwwwww me ;) .... but no, I don't know Polish

ShaneBeee avatar Jul 13 '22 02:07 ShaneBeee

Note: Nicofisi required for pull request acceptance.

TheLimeGlass avatar Jul 13 '22 02:07 TheLimeGlass

Discussion continues in #5164, good work :)

Nicofisi avatar Oct 14 '22 15:10 Nicofisi