Skript icon indicating copy to clipboard operation
Skript copied to clipboard

Add filter support to ExprItemsIn

Open Pikachu920 opened this issue 3 years ago • 1 comments

Description

Adds supports to get only certain item types when using ExprItemIn (e.g. all swords in player's inventory). Marking as draft because I haven't contributed for a while and am not sure on Skript code style and new APIs. Particularly, I would appreciate a double check of test script and my ItemType comparison (in matchesTypeFilter) as it currently acts funky with named/enchanted items.

To-do:

  • [x] Ensure proper method is being used for itemtype comparison
  • [x] Ensure expression works as expected with named/enchanted/etc items
  • [x] Test iterator method more
  • [x] Ensure test script functions properly

Target Minecraft Versions: All Requirements: None Related Issues: #4612

Pikachu920 avatar Feb 20 '22 01:02 Pikachu920

have a sec to review pls? @APickledWalrus

Pikachu920 avatar Apr 05 '22 23:04 Pikachu920

Addressed reviews, but this is now pending #5077 as the test is failing due to an NPE in ExprSets

Pikachu920 avatar Oct 12 '22 23:10 Pikachu920

ExprXOf.sk is failing when it shouldn't be. Changes made in this pull request have affected that test.

TheLimeGlass avatar May 03 '23 05:05 TheLimeGlass