Skript
Skript copied to clipboard
Add filter support to ExprItemsIn
Description
Adds supports to get only certain item types when using ExprItemIn (e.g. all swords in player's inventory). Marking as draft because I haven't contributed for a while and am not sure on Skript code style and new APIs. Particularly, I would appreciate a double check of test script and my ItemType comparison (in matchesTypeFilter) as it currently acts funky with named/enchanted items.
To-do:
- [x] Ensure proper method is being used for itemtype comparison
- [x] Ensure expression works as expected with named/enchanted/etc items
- [x] Test iterator method more
- [x] Ensure test script functions properly
Target Minecraft Versions: All Requirements: None Related Issues: #4612
have a sec to review pls? @APickledWalrus
Addressed reviews, but this is now pending #5077 as the test is failing due to an NPE in ExprSets
ExprXOf.sk is failing when it shouldn't be. Changes made in this pull request have affected that test.