Skript
Skript copied to clipboard
SkriptLang
🚀 Add inventory raw slot expression
Description
This PR Adds a new expression to get the raw inventory slot number, this is a unique number for each view, it basically consider the current opened inventories (top and bottom) as a 1 inventory that begins from the top left
Target Minecraft Versions: Any Requirements: None Related Issues: #4461
I'm concerned that this is handled as a number whereas the regular
slotsupports getting and setting the item - even if Bukkit doesn't handle this as easily you could try and support this for parity with the existing expression to avoid confusing users.
I think the idea of raw slot is to just get the slot number, otherwise users can use clicked slot, having both clicked slot and raw slot as a slot is redundant IMO
There is the index of %slots% expression. Maybe this expression could be something like raw slot index to clear up any potential confusion?
Maybe that is more confusing though actually lol
There is the
index of %slots%expression. Maybe this expression could be something likeraw slot indexto clear up any potential confusion?Maybe that is more confusing though actually lol
Should this not be raw index instead of raw slot then?
I was thinking of adding this to index of slot as Kenzie said, but thought not then, if that's a better approach then i will try it out if possible
More discussion here
Not a fan of this addition, raw slot is basically never used.
It's indeed needed in some places if not many when you open 2 inventories the usual slot number will continue after 63 in the below gui while the raw will begin from 0
Was there a reason we didn't change this to return Slot? I forget
Here is more info about our discussion
EDIT: New discussion in skript-dev
I don't believe Skript should have this expression. I'm removing my review request from this pull request.