Formalize the clicked syntaxes

[TheLimeGlass]

When this gets merged, reminder to let the changelog know that existing click action will not work anymore, it is only clicked action and clicked type, simple and easier to understand than how it currently is`

---

Description

Make the clicked syntaxes more proper. Skellett has had these removed for some time now, so users should be adapted to Skript's synatxes now. It was called inventory action as Skellett had clicked action, but now Skript has the freedom to change it back to be proper. I also removed click action as being a ClickedType. It should have never been associated with type, and users will have to update to the new proper standards. click action has a very lower usage in favor of click type click action will not work so that the wrong type isn't referenced. And inventory action/clicked action will be an https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html

---

Target Minecraft Versions: any Requirements: none Related Issues: none

[TPGamesNL]

Wouldn't it be better to remove click action altogether because it is ambiguous?

[TheLimeGlass]

I removed the clicked action from the clicked type naming. It's now proper as what TP said.

[TheLimeGlass]

When this gets merged, reminder to let the changelog know that existing click action will change it's functionality to inventory action

ClickedType = old InventoryAction = new for clicked action

[TPGamesNL]

I removed the clicked action from the clicked type naming. It's now proper as what TP said.

My suggestion was to remove the syntax click action altogether, meaning not have it be an option for both, because it isn't clear whether it is a ClickType or an InventoryAction.

[TheLimeGlass]

I removed the clicked action from the clicked type naming. It's now proper as what TP said.

My suggestion was to remove the syntax click action altogether, meaning not have it be an option for both, because it isn't clear whether it is a ClickType or an InventoryAction.

I think clicked action has always been clear that it's inventory action. Addons have been referring clicked action to InventoryAction since 2014 Umbaska days.

[TPGamesNL]

I think clicked action has always been clear that it's inventory action. Addons have been referring clicked action to InventoryAction since 2014 Umbaska days.

Don't you think double clicking is a click action?

[TheLimeGlass]

I think clicked action has always been clear that it's inventory action. Addons have been referring clicked action to InventoryAction since 2014 Umbaska days.

Don't you think double clicking is a click action?

What do you mean double click? https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html

I don't even know what a double click is, isn't that pickup all to cursor?

[TPGamesNL]

What do you mean double click? https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html

I don't even know what a double click is, isn't that pickup all to cursor?

I'm not talking about anything related to Minecraft or Skript, I'm talking about the English language. When you hear 'double click', would you consider that a click action?

[TheLimeGlass]

I don't think click action should mean InventoryAction or ClickType. The name is ambiguous, it can be interpreted as either. This PR itself shows that the interpretation isn't clear.

Just click action? clicked action is fine? I don't understand what you mean.

[TPGamesNL]

Both, click[ed] action

[TheLimeGlass]

Both, click[ed] action

clicked action has always meant InventoryAction in every addon since the early days, this pull request fixes what should have been done a long time ago when I stated the exact same thing 5 years ago.

[TPGamesNL]

When I say it's ambiguous I'm not talking about whatever Skript and addon history has to say about it, I'm saying that, in the English language, the word click action (or clicked action) can refer to either (if I had to choose I'd go with ClickType rather than InventoryAction).

This is why I brought up the example, forgot Bukkit, Minecraft and Skript meanings: when you think of a 'double click', would you call this a 'click action'? Or, more in terms of Minecraft stuff: consider a double click, and consider swapping an item from the hotbar. Which would you call a click action?

[TheLimeGlass]

When I say it's ambiguous I'm not talking about whatever Skript and addon history has to say about it, I'm saying that, in the English language, the word click action (or clicked action) can refer to either (if I had to choose I'd go with ClickType rather than InventoryAction).

This is why I brought up the example, forgot Bukkit, Minecraft and Skript meanings: when you think of a 'double click', would you call this a 'click action'? Or, more in terms of Minecraft stuff: consider a double click, and consider swapping an item from the hotbar. Which would you call a click action?

Clicked action doesn't sound close to type at all. Clicked action more refers to an action of dropping cursor to inventory

[TheLimeGlass]

No need to re-request, same situation as prev.

click action should be removed because it is ambiguous.

I don't agree with that statement.

[sovdeeth]

in response to limeglass's post on skunity discord soliciting opinions:

clicked action specifically makes no sense to me. What action are you clicking on? click action I would interpret as inventory action, but it's ambiguous enough that removing it could be a safer option. I can easily see someone thinking it's the action used to click, ie: left or right mouse. click type and inventory action are nice and separate and having one that's a bit of both could be confusing.

I'm ok with keeping click action around or removing it, but if pressed to choose, I would suggest removing click action entirely.

[TheLimeGlass]

clicked action specifically makes no sense to me. What action are you clicking on?

An inventory action https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html

[TheLimeGlass]

Removed click action as the old usage referred to clicked type. that is now not possible to avoid incorrect type of older versions, must be clicked action or inventory action for https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html now.

Everything is standardized now.

[sovdeeth]

clicked action specifically makes no sense to me. What action are you clicking on?

An inventory action https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html

You're not clicking on the action, so clicked action makes no sense. You're doing an action, involving clicking, so click action does make sense.

clicked action should be removed.

[TheLimeGlass]

clicked action specifically makes no sense to me. What action are you clicking on?

An inventory action https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html

You're not clicking on the action, so clicked action makes no sense. You're doing an action, involving clicking, so click action does make sense.

clicked action should be removed.

click action would conflict with the older versions because it currently reflects ClickType

[sovdeeth]

clicked action specifically makes no sense to me. What action are you clicking on?

An inventory action https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryAction.html

You're not clicking on the action, so clicked action makes no sense. You're doing an action, involving clicking, so click action does make sense. clicked action should be removed.

click action would conflict with the older versions because it currently reflects ClickType

ok just remove clicked action too and all's good. that was my original suggestion anyway

[TheLimeGlass]

ok just remove clicked action too and all's good. that was my original suggestion anyway

Then there is no point in this pull request, that's the main change. It's to standardize the synatxes that reflect how Skript addons have always done so.

[sovdeeth]

ok just remove clicked action too and all's good. that was my original suggestion anyway

Then there is no point in this pull request, that's the main change. It's to standardize the synatxes that reflect how Skript addons have always done so.

no there's plenty of point Right now, click[ed] action is ambiguous and confusing. After this change, it should be click type -> the type of click, left, right whatever inventory action -> the action happening in the inventory, pick up, place, etc.

clicked type and clicked action should both be tossed out, just because they're not grammatical at all and make very little sense. It doesn't matter what they refer to, they're wrong either way.

-	       TYPE(5, ClickType.class, "click type", "click (type|action)"),
-	       ACTION(6, InventoryAction.class, "inventory action", "inventory action"),;
+ 		TYPE(5, ClickType.class, "click type", "click type"),
+		ACTION(6, InventoryAction.class, "inventory action", "inventory action");

[moraedu]

ok just remove clicked action too and all's good. that was my original suggestion anyway

Then there is no point in this pull request, that's the main change. It's to standardize the synatxes that reflect how Skript addons have always done so.

I think there's little point in trying to keep syntax compatibility between Skript syntaxes and addons, as a matter of fact addons shouldn't have been implementing these features but PRing them to Skript since that's what it is here for, though we can't deny that they have done so already I still firmly believe that as far as Bukkit/Spigot features goes, Skript should be the one dictating the implementation of such features and not addons, be it as a syntax or design altogether.