aidoku-community-sources icon indicating copy to clipboard operation
aidoku-community-sources copied to clipboard

feat(libgroup): implementation of login to account SocialLib

Open vlapskii opened this issue 1 year ago • 11 comments

This feature gives access to NSFW libgroup sites and access to manga chapters tagged 18+, which are not available without an account (closes #805)

Checklist:

  • [ ] Updated source's version for individual source changes
  • [ ] Updated all sources' versions for template changes
  • [ ] Set appropriate nsfw value
  • [ ] Did not change id even if a source's name or language were changed
  • [ ] Tested the modifications by running it on the simulator or a test device

vlapskii avatar Jan 03 '25 21:01 vlapskii

When would it be fixed?

maksim-katafalk avatar Jan 04 '25 21:01 maksim-katafalk

I'm spending the New Year holidays with my family and my laptop is not always at hand. I'm currently writing code to parse web pages for authorization, so maybe at 8-9 january, idk sorry.

vlapskii avatar Jan 04 '25 21:01 vlapskii

Btw thanks for the work

maksim-katafalk avatar Jan 04 '25 22:01 maksim-katafalk

Well... I can't make this function until aidoku-rs doesn't have a method to disable request redirect :skull:

SocialLib in endpoint auth/login giving a response with a redirect on HTTP, and it seems breaks server side, because it redirects on first endpoint when it must redirect on page with hidden tokens in html code. Recent browsers use https protocol by default and don't notice http, they just replace http with https in URL when aidoku-rs redirects directly.

vlapskii avatar Jan 05 '25 11:01 vlapskii

Well, it turns out we have to wait until the Aidoku developer fixes this bug. And as I understand it, it can take a long time.

maksim-katafalk avatar Jan 05 '25 15:01 maksim-katafalk

that's not bug

vlapskii avatar Jan 05 '25 16:01 vlapskii

but what is needed to solve this problem?

maksim-katafalk avatar Jan 05 '25 18:01 maksim-katafalk

I wouldn't even think of adding ability of disabling redirect, if I didn't know about this case. That's why it's not a bug

vlapskii avatar Jan 05 '25 18:01 vlapskii

I see, so we'll have to wait until the method to disable request redirect appears? And it's just a matter of time until they add this feature? Edit: че то я затупил и понял что необязательно на английском писать. Получается надо ждать пока разработчик изменит функцию перенаправления или че то в этом роде?

maksim-katafalk avatar Jan 05 '25 19:01 maksim-katafalk

Yes. We have to wait until the method is added to the API, but as far as I know, a new Aidoku API (0.7) will appear soon, which will have this method, and I have rewrite source for the API.

Ну да по сути надо ждать пока не появится метод в API, но вроде бы скоро будет совершенно новый API, где это можно будет сделать, поэтому мне придется переписывать расширение, оно работать-то будет, но просто будет с пометкой легаси, пока не перепишу под новый. Кстати, о языке, здесь я буду исключительно на английском коммуницировать чисто из правила хорошего тона, это соообщение — исключение.

vlapskii avatar Jan 09 '25 20:01 vlapskii

Got it, all that's left is to wait for the new version of the app to come out. Thanks for the info, I'm looking forward to you fixing this.

maksim-katafalk avatar Jan 10 '25 06:01 maksim-katafalk