Giacomo Stevanato
Giacomo Stevanato
> So having `SystemState` still take an `&mut World` but then have `system_params` (bikeshed) functions on both `World` and `DeferredWorld`? The issue is that currently `SystemState` is lazily initialized the...
> Sorry, what do component hooks have to do with that? They are the main users of `DeferredWorld`, so that's probably where you want to get system states/parameters. > And...
In addition to the previous observation, `rustdoc` doesn't respect the `linker` option in Cargo's `config.toml`, you need to explicitly set it in the `rustdocflags`: ```toml [target.x86_64-pc-windows-msvc] rustdocflags = ["-Clinker=rust-lld.exe"] ```...
https://github.com/rust-lang/rust/pull/126245 has been merged, though unfortunately it will be enabled only with the 2024 edition.
> `ReflectBox` cannot be publicly constructed Nitpick: it can, since `ReflectRemote::into_wrapper` offers a way to do so. --- I would also add to the caveats that this way of reflecting...
> ```rust > let mut boxed: Box = Box::new(123u8); > boxed = Box::new(456u16); > ``` What I mean is that you won't be able to do this if `boxed` is...
Since the example I gave in https://github.com/bevyengine/bevy/pull/14776#issuecomment-2293830021 may seem a bit weird/artificial, here's another one that might seem more reasonable: ```rust #[derive(Reflect)] #[reflect(from_reflect = false)] struct Foo { #[reflect(remote =...
> Less certain about supporting Option in bundles. Largely because bundle usage have been reduced in prominence in general and I worry about adding complexity for a niche abstraction. But...
> I imagine enum bundles could take advantage of the same optimisations as `Option`. Yes, the only reason this isn't done yet is deciding how to expose the interface for...
> I personally see EitherOfN as the more ergonomic option as it doesn't require you to write out a transient type. Not precisely sure how well you could extract the...