testup-2 icon indicating copy to clipboard operation
testup-2 copied to clipboard

TestUp hiding crashes?

Open thomthom opened this issue 6 years ago • 3 comments

https://github.com/SketchUp/testup-2/blob/a407d391ac79aacd9a03bed0af395783f97f775c/tests/SketchUp%20Ruby%20API/TC_Geom_PolygonMesh.rb#L141-L146

This crashes SU when run from the Ruby Console:

polygonmesh = Geom::PolygonMesh.new(-1)

But when run from TestUp's dialog it doesn't. The Wait cursor appears, but eventually it's possible to click. Looks like the access violation is being swallowed for some reason - not sure why.

Needs investigation. Better to crash than to end up in a weird state like this.

thomthom avatar Apr 03 '18 17:04 thomthom

Odd. I had this skipped in SUMT with

skip("Fix this, Bug Splat!") if SU_VERS_INT < 19

When I remove that, it Bug Splats, and the UDP reporter stops on that test. Whether the whole file is run or just that test...

If you want to check, after setup, comment out the skip, run udp_receiver.rb from a command prompt, and the following in the Ruby console -

Whole File
SUMT.run f:%w[geom/TC_PolygonMesh.rb], gu:true

Single Test
SUMT.run f:%w[geom/TC_PolygonMesh.rb], n:'test_initialize_negative_num_points', gu:true

MSP-Greg avatar Apr 06 '18 02:04 MSP-Greg

Yea, I'm not sure what is going on. I suspect there is some oddness with the webdialog that interfere... It consistently crash with not run from within TestUp.

thomthom avatar Apr 06 '18 09:04 thomthom

Been AFK for several days. I also have a Bug Splat on

  def test_initialize_negative_num_polygons
    # Expected this to fail since creating a polygon mesh with negative number
    # of polygons sounds a bit odd.
#    skip("Fix this, Bug Splat!") if SU_VERS_INT < 19
    polygonmesh = Geom::PolygonMesh.new(4, -2)
    assert_kind_of(Geom::PolygonMesh, polygonmesh)

MSP-Greg avatar Apr 10 '18 22:04 MSP-Greg