Jsx3 andrii

[andrii-antiukhov]

In this files i made changes, but not all was refactored to JSX3 (need to do this)

client/shared/Fi.re
client/shared/React.re
client/shared/ReactOld.re

All components in folder client/src/components/ was refactored to JSX3. But i did not run compiler, so maybe there are some errors. @jchavarri Not sure about changing React.re to ReactOld.re I did this because last time me and Feihong found bug, so i created other React.re But i do not know do we need this for JSX3 Sorry. If not need thiod changes, i will remove ReactOld from all files in this PR.

[andrii-antiukhov]

Hi @jchavarri Today i successfully up sketch on my local Mac and i did some refactoring. So not so bad was today. I refactored Embed.re and ReLoadable.re and fixed some other issues. Please, review this PR and you can merge it to branch jsx3 if need. For me and @maxlibin left to refactor 2 files

 src_editor/Editor_Blocks.re
 src_editor/Editor_Links.re

But maybe we will do this next time, because this files not so simple to refactor. Thanks!

[maxlibin]

Hi @jchavarri Today i successfully up sketch on my local Mac and i did some refactoring. So not so bad was today. I refactored Embed.re and ReLoadable.re and fixed some other issues. Please, review this PR and you can merge it to branch jsx3 if need. For me and @maxlibin left to refactor 2 files

 src_editor/Editor_Blocks.re
 src_editor/Editor_Links.re

But maybe we will do this next time, because this files not so simple to refactor. Thanks!

https://github.com/Sketch-sh/sketch-sh/pull/339

[andrii-antiukhov]

@jchavarri Sorry i can not finish properly file src_editor/Editor_Blocks.re too complicated for me. I done main part but i do not know how to refactor some old code. So you can look and maybe can fix rest part of code. Sorry. File src_editor/Editor_Links.re was refactored full. Sorry, i do not have types because can not up compiler, difficult to understand logic. So i hope i help you how i can. I tried do everything in best way, but not enough knowledge. So me and Max waiting for your instructions for the next opensource day. If it is still make sense for us. Thanks!