Gergely Brautigam

Ginkgo v1 flow broken after v2 support was added

7

https://github.com/vim-test/vim-test/issues/632 added v2 support, which is fantastic. But sadly, the pr doesn't take into account v1 and added / removed a flag which is not there for v1. So now,...

[Task] Stop using `s` as an indicator that we are returning a list

2

For example: ```go DescribeNodeGroupStack(ctx context.Context, nodeGroupName string) (*Stack, error) DescribeNodeGroupStacks(ctx context.Context) ([]*Stack, error) ``` This is super annoying and actually caused a bug to happen: https://github.com/weaveworks/eksctl/issues/5217 It's because our unit...

[Task] Increase Unit test coverage of create cluster - Karpenter

1

Part of https://github.com/weaveworks/eksctl/issues/5315 Test the Karpenter creation flow. This might be easy if you can nicely mock the call to create Karpenter. This might require https://github.com/weaveworks/eksctl/issues/5406 to be done first.

[Task] Increase Unit test coverage of create cluster - nodegroups

2

Part of https://github.com/weaveworks/eksctl/issues/5315 The testing of the nodegroups will be a bit finicky because you will have to also start mocking kubernetes client calls to check if the node is...

[Task] Increase unit test coverage of create cluster - brought subnet topology

1

Part of https://github.com/weaveworks/eksctl/issues/5315 Right now, `create cluster` unit test works by generating the infrastructure including the subnets and the VPC. A next step would be to be able to define...

Part of https://github.com/weaveworks/eksctl/issues/5315 Test the flux integration. Might require mocking the command part because flux is trying to run the flux binary.

Part of https://github.com/weaveworks/eksctl/issues/5315 Should include testing the part where it calls the endpoint to be set to private.

[Task] remove usages of aws-sdk-go v1 where possible

4

We still have a couple of places where we use sdk v1 but don't have to. Places where `aws.String` is used for example. We should clean those up.

[Task] Remove deprecated DisableASGTagPropagation

1

### Description https://github.com/weaveworks/eksctl/pull/4962 removed the usage of this field. After a while, delete this field.

AnonymusCredentials is not respected by S3 API

3

### Describe the bug This example from the config: ```go cfg, err := config.LoadDefaultConfig(context.TODO(), config.WithCredentialsProvider(aws.AnonymousCredentials{}), ) if err != nil { log.Fatalf("failed to load config, %v", err) } client :=...