make-sense icon indicating copy to clipboard operation
make-sense copied to clipboard

Polygon Spec

Open gdj0nes opened this issue 5 years ago • 3 comments

Polygon's should implement follow the standard polygon spec. Doing so significantly reduces the complexity of etl on polygons because they will be valid in libraries like shapely

gdj0nes avatar Aug 28 '19 19:08 gdj0nes

hi @gdj0nes ! Could you elaborate a little bit on what you have in mind? You mean that makesense.ai should offer export in this format?

SkalskiP avatar Aug 28 '19 19:08 SkalskiP

Polygons you draw should be validated to be actual polygons before being saved, that polygons can have cutouts (see spec), and that the export data structure is correct (polygon should have its points defined in an ordered ring where the first and last point are the same)

gdj0nes avatar Aug 28 '19 19:08 gdj0nes

@gdj0nes I partly agree with you and partly disagree. Or (perhaps) I still don't fully understand what you mean. As far as export data structure is concerned, we are planning to support file formats that already function as a way to describe polygons in ML-related tasks. Such as VGG or COCO. They have a predefined structure. We can of course follow these rules in the case of CSV file, which has the structure imposed by us.

As far as validation is concerned, I agree that we should verify whether the given points form a polygon.

Did I understand correctly what you meant?

SkalskiP avatar Aug 28 '19 19:08 SkalskiP