make-sense
make-sense copied to clipboard
SkalskiP
Draft: Feature/drop image
Changelog:
- [ ] Add Remove Image Button
- [ ] Add Remove Image Toolbar
- [x] Fix Linter
Codecov Report
Merging #274 (7c10578) into develop (855d8ed) will decrease coverage by
0.35%. The diff coverage is17.33%.
@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
- Coverage 14.34% 13.98% -0.36%
===========================================
Files 150 151 +1
Lines 4379 4396 +17
Branches 803 794 -9
===========================================
- Hits 628 615 -13
- Misses 3605 3635 +30
Partials 146 146
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/hooks/useContextMenu.ts | 0.00% <0.00%> (ø) |
|
| src/logic/actions/EditorActions.ts | 21.68% <0.00%> (ø) |
|
| src/logic/import/coco/COCOImporter.ts | 0.00% <0.00%> (ø) |
|
| src/logic/render/PrimaryEditorRenderEngine.ts | 20.00% <0.00%> (ø) |
|
| src/utils/SizeUtil.ts | 0.00% <ø> (ø) |
|
| src/utils/VirtualListUtil.ts | 0.00% <ø> (ø) |
|
| src/utils/XMLSanitizerUtil.ts | 0.00% <ø> (ø) |
|
| src/views/Common/ImageButton/ImageButton.tsx | 0.00% <0.00%> (ø) |
|
| src/views/Common/TextButton/TextButton.tsx | 0.00% <0.00%> (ø) |
|
| src/views/Common/VirtualList/VirtualList.tsx | 0.00% <0.00%> (ø) |
|
| ... and 10 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@SkalskiP I don't quite understand how to manipulate the image Repository, for now I'm stuck with button with alert ("Not Implemented")
@rasyidf do you need some help?
Yes, I still don't understand where to put the deletion. this changes is safe to merge anyways. I provided // TODO:
I'm good at react, but don't have any idea about Redux state and repository management. how the image preserved etc.
Is it okay if I run the linter? it will add approximately 65 file changes. I fixed some of my mistakes back then when migrating to vite. @SkalskiP. well if don't I'll keep it as clean as possible.