make-sense icon indicating copy to clipboard operation
make-sense copied to clipboard

Published 20 hours ago • verified publisher icon SkalskiP

Toggle Drag mode with hotkey h, Add Copy and Paste for Labels, Updated Readme

Open matkg opened this issue 2 years ago • 3 comments

Im open for improvements as i just started using react.

https://github.com/SkalskiP/make-sense/issues/75

Pre-flight checklist

  • [ ] Unit tests for all non-trivial changes
  • [x] Tested locally
  • [x] Updated wiki

matkg avatar Sep 16 '21 09:09 matkg

Hello @Skiid 👋. Thank you very much for your interest in make-sense :) If that's ok, I'll do a review of your code over the weekend. I need to think if I have any better idea to implement those 2 functionalities than those that you proposed.

SkalskiP avatar Sep 16 '21 18:09 SkalskiP

@SkalskiP Alright take your time. I had some problems finding the right code formatter and thats why there are so many changes in RectRenderEngine.ts.

matkg avatar Sep 17 '21 10:09 matkg

@Skiid don't worry I recently added linter I now I constantly push new formatting in PRs.

SkalskiP avatar Sep 17 '21 15:09 SkalskiP