Hytilities icon indicating copy to clipboard operation
Hytilities copied to clipboard

Locraw outputs still are shown in the ReplayMod studio

Open ChachyDev opened this issue 4 years ago • 2 comments

Image of bug

None. Example output however:

{"server":"mini250J","gametype":"BEDWARS","mode":"BEDWARS_EIGHT_TWO","map":"Lightstone"}

Description

When using the ReplayMod ("RM") studio the locraw output is still shown. This is most likely because we only cancel the locraw message when the Player is active on Hypixel but not if they were in the RM studio...

How to reproduce?

  1. Load the game with Hytilities & RM
  2. Join the Hypixel Server mc.hypixel.net
  3. Use the mod for a decent amount of time, locraw should've been used once or twice by then
  4. Disconnect from Hypixel and go into Replay Videos
  5. Choose your latest Replay video
  6. Watch the replay and locraw messages appear in chat

Possible solutions

  • Detect for the ReplayStudio and cancel the locraw messages

Unsupported solutions

  • Prevent ReplayMod from picking up the chat packets containg locraw

ChachyDev avatar Jun 03 '21 15:06 ChachyDev

Johni suggests using !mc.isSingleplayer() && mc.getCurrentServerEntry() == null && !mc.isConnectedToRealms() to detect if it's a Replay world or not

ghost avatar Jun 03 '21 15:06 ghost

In my experience, Hytils Locraw just sometimes shows the output of locraw and sometimes doesn't

Wyvest avatar Jun 17 '21 09:06 Wyvest