Sjoerd Langkemper comments

Results 204 comments of


                                            Sjoerd Langkemper

Performance issues when parsing null conditional operators in C#

In that case, perhaps it's simpler to just map `a?.b` to `a.b`. That loses the distinction between the two, but as you said that might not be such a big...

Performance issues when parsing null conditional operators in C#

[fix(c#): use elvis operator to prevent exponential trees by brandonspark · Pull Request #8162 · returntocorp/semgrep](https://github.com/returntocorp/semgrep/pull/8162)

Allowing errors with convertWarningsToExceptions doesn't work with process isolation

Another trick I found to prevent output on stderr is to close it: fclose(STDERR);

proposal/new requirement - served filename in content-disposition header must follow correct encoding

Perhaps [CWE - CWE-838: Inappropriate Encoding for Output Context (4.9)](https://cwe.mitre.org/data/definitions/838.html) is more relevant.

Precedence incorrect between or and conditional access

Test case: ``` ===================================== Precedence between or and conditional access ===================================== var a = x || x?.C; --- (compilation_unit (global_statement (local_declaration_statement (variable_declaration type: (implicit_type) (variable_declarator name: (identifier) (equals_value_clause (binary_expression left:...

associated type `Alpha` must be specified

@vaidehijoshi ?

Increment on a field with custom cast checks for method on one class but calls another

Thanks. This now works as expected on 9.48.0. Perhaps it should also be merged into 10.x? Other than that, I am happy.

CLI needs to ignore desktop.ini, thumbs.db and album art files in recursive mode

Would it help if you pass `--extention=mp3`?

Feature reuqest: template support

I also would like to be able to copy markdown links. Whether that is through templates or not doesn't matter to me.

Semgrep changing current directory causes unexpected file resolving behaviour

This is still a problem. Could you reopen this? ``` /myproject # semgrep --version 0.94.0 /myproject # ls -l semgrep.yml -rw-r--r-- 1 root root 3014 Jan 27 09:03 semgrep.yml /myproject...