Shapes icon indicating copy to clipboard operation
Shapes copied to clipboard

Added: ability to change fill type

Open equinox2k opened this issue 5 years ago • 4 comments

Exposed ability to change fill type as per...

https://github.com/SixLabors/Shapes/issues/65

May need guide on the ImageSharp Graphics options side

@tocsoft

equinox2k avatar Aug 13 '19 14:08 equinox2k

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 13 '19 14:08 CLAassistant

fairly certain this won't be sufficient in all cases, because our render wont necessarily use the clipper internally. We actually use https://github.com/SixLabors/Shapes/blob/4f12a19a60b597c709618d972b2eca16e252e4ee/src/SixLabors.Shapes/InternalPath.cs#L180 to find intersections for filling purposes thats the one that will need to be modified to support the different fill types to determine inside outsideness.

tocsoft avatar Aug 22 '19 08:08 tocsoft

the reason the cla stuff isn't working is because the commit is seen as being created by your petertribe account but then you've signed the CLA as equinox2k its your other account that will need to sign the CLA for it to allow the commit to be merged.

tocsoft avatar Aug 22 '19 08:08 tocsoft

@tocsoft sorted out cla eventually had to create the needed account on GitHub luckily was available :)

I may need help with the FindIntersections as not sure what exactly should be done.

petertribe avatar Aug 30 '19 00:08 petertribe