FlutterRadioPlayer
FlutterRadioPlayer copied to clipboard
Sithira
Remove unused class, change initialisation steps, fix metadata, upgrade dependencies
- removed unused
StreamingCore.ktthat was causing build problems - upgraded kotlin version to 1.7.21
- upgraded plugin version to 2.0.1 to indicate a fix to 2.0.0
had to fix a NullPointerException when the default source is not acc so the plugin was updated to v2.0.2 accordingly
fixed the iOs side, fetching metadata from a different type (group instead of item)
- moved player initialization to before media sources are set to ensure the player is "always" initialized correctly
- disabled showing a stop button in the notification player controls because when the player is stopped, the service will be unbound/unregistered so the playlist cannot be resumed normally
- added some TODOs with ideas to consider
- upgraded Android gradle
@Sithira when you get to this message, please contact me if you want to discuss what happened in this PR because at this point I have heavily modified the Android side of the plugin in such way that it conforms to my current needs. My opinion is that this plugin is on the right track but requires more work and needs to do some things differently in order to become more powerful and usable to a common developer. Now that I've become somewhat familiar with it, I would love to discuss its future with you as I won't have the time to fix it alone and I'm sure you're busy, too.
@markfili i would love have a discussion with you regarding the changes you have made
@markfili I'm sorry for the extreme delay. I know this is way too late. But would be rebase your changes and resubmit your PR ? Your changes seems promising
Hello! I would love to do that but I will be able to do that after New Year if that is ok with you
On 23 December 2023 10:39:10 CET, Sithira Munasinghe @.***> wrote:
@markfili I'm sorry for the extreme delay. I know this is way too late. But would be rebase your changes and resubmit your PR ? Your changes seems promising
-- Reply to this email directly or view it on GitHub: https://github.com/Sithira/FlutterRadioPlayer/pull/78#issuecomment-1868253804 You are receiving this because you were mentioned.
Message ID: @.***>
That is fine. Thank you for your time. Much appreciated
On Sat, Dec 23, 2023 at 3:32 PM Marko Filipović @.***> wrote:
Hello! I would love to do that but I will be able to do that after New Year if that is ok with you
On 23 December 2023 10:39:10 CET, Sithira Munasinghe @.***> wrote:
@markfili I'm sorry for the extreme delay. I know this is way too late. But would be rebase your changes and resubmit your PR ? Your changes seems promising
-- Reply to this email directly or view it on GitHub:
https://github.com/Sithira/FlutterRadioPlayer/pull/78#issuecomment-1868253804
You are receiving this because you were mentioned.
Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/Sithira/FlutterRadioPlayer/pull/78#issuecomment-1868258212, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6V3BJ3GNOXVNHDTNJYI7TYK2TZRAVCNFSM6AAAAAAUG472I2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGI2TQMRRGI . You are receiving this because you were mentioned.Message ID: @.***>
@Sithira Hello!
here you go, I've synced changes in this PR with lastest changes on your repository and I suggest you test everything thoroughly before merging so you know for sure what was changed and how it behaves now :) there might be some Flutter package updates you'll have to solve but I think it's good to update deps from time to time :)