Unicorn icon indicating copy to clipboard operation
Unicorn copied to clipboard

Bump SharpZipLib from 0.86.0 to 1.3.3 in /src/Unicorn.Remoting

Open dependabot[bot] opened this issue 2 years ago • 3 comments

Bumps SharpZipLib from 0.86.0 to 1.3.3.

Release notes

Sourced from SharpZipLib's releases.

v1.3.3

Another minor release, containing security fixes and smaller bugfixes.

Fixes:

Smaller changes:

  • 🔨 [#604] Move the Password property from DeflaterOutputStream into ZipOutputStream by Richard Webb
  • 🔨 [#625] Make BZip2Constants static instead of sealed by Richard Webb
  • 🔨 [#626] make a couple of private functions static by Richard Webb

Other changes (not related to library code):

v1.3.2

Another minor release, containing security fixes and smaller bugfixes.
Additionally, this version will have an additional target framework, .NET Standard 2.1, which will see some speed improvements when used in newer versions of .NET (Core), mainly in Bzip2.

Features

Smaller fixes and optimizations

Other changes (not related to library code)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Feb 01 '22 16:02 dependabot[bot]

I had a quick look - SharpZipLib is a dependency brought in by Sitecore: Sitecore 10.0 and lower is SharpZipLib 0.86 Sitecore 10.1 is SharpZipLib 1.2 Sitecore 10.2 is SharpZipLib 1.3.2

I wonder if it can be removed from being directly referenced?

markgibbons25 avatar Feb 15 '22 09:02 markgibbons25

To be perfectly honest, I'm not even sure this part of the codebase is relevant at all. I was initially surprised that Unicorn had a reference at all to SharpZipLib since I can't think of a reason why it would be needing it. It appears to be only used in the Unicorn.Remoting project - and that project has all the qualities of a new Raiders of the Lost Ark movie :D

image

I think I can axe this entire folder.

cassidydotdk avatar Feb 15 '22 09:02 cassidydotdk

Sounds good, I think the same goes for the test project in Rainbow.

markgibbons25 avatar Feb 15 '22 09:02 markgibbons25