jss icon indicating copy to clipboard operation
jss copied to clipboard

sitecoreContext.pageEditing does not take into account editing a related item in Content Editor from Experience Editor

Open mjarosch opened this issue 2 years ago • 1 comments

Description

The sitecoreContext.pageEditing property still reports true when you are editing a related item in Content Editor from Experience Editor. The pageEditing property needs to also take into account that the "sc_ce" query string parameter isn't "1" in Experience Editor.

Expected behavior

The sitecoreContext.pageEditing property reports false when you are editing a related item in Content Editor from Experience Editor.

Steps To Reproduce

  1. Add appropriate html markup in a component to match the EditFrame html. Add the Edit Frame default "Edit Related Item" button markup.
  2. View the component in Experience Editor.
  3. Click the "Edit Related Item" button.
  4. All of the json from the "scChromeData" span now appears, since the Experience Editor css is no longer being applied, since the page is not editable in this state.

Possible Fix

Your Environment

  • Sitecore Version: 10.2
  • JSS Version: 20.1.2
  • Browser Name and version: Edge
  • Operating System and version (desktop or mobile): Windows 10
  • Link to your project (if available):

Screenshots

image image

mjarosch avatar Dec 02 '22 06:12 mjarosch

@mjarosch Thank you for the report, added item to our inbox to discuss with the team

illiakovalenko avatar Dec 19 '22 12:12 illiakovalenko

This has been automatically marked as stale because it has not had recent activity. It will be closed if there is no further activity within 30 days. You may add comments or the 'keep' label to prevent it from closing. Thank you for your contributions.

stale[bot] avatar Jul 04 '24 00:07 stale[bot]