Sitecore
Added package hash validation on restore
This PR contains updated version of Invoke-PackageRestore.ps1 script: it checks hashes of downloaded packages.
It helps to prevent build failure on a later stage if some package was not fully downloaded or is corrupted
FYI, the reason why we haven't done this before is that it takes for ever to do if your packages are stored on for example a Azure Storage file share. Have you tested how long time it tasks to check all packages using a remote file share?
@pbering Unfortunately I have no chance to test it with a remote file share at this moment. Feel free to close this PR without merging it if these changes are not needed.
Hoping someone who is using a remote fileshare can take this for a test-drive.
@jeanfrancoislarente / @pbering just want to clarify that Remote file share is the equivalent of Azure File Share. I can help testing this next week if this is still required.
The moment it’s not on the local network there’s still a limitation with bandwidth/throughput.
It would be nice to know the difference in time between a local network and an azure file share before we move forward with the PR.
Get Outlook for iOShttps://aka.ms/o0ukef
From: Vincent Lui [email protected] Sent: Saturday, December 12, 2020 6:21:15 PM To: Sitecore/docker-images [email protected] Cc: Jean-François Larente [email protected]; Mention [email protected] Subject: Re: [Sitecore/docker-images] Added package hash validation on restore (#380)
@jeanfrancoislarentehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjeanfrancoislarente&data=04%7C01%7Cjean-francois.larente%40sitecore.com%7C5b38beceb4cc454a77ee08d89ef4a017%7C91700184c3144dc9bb7ea411df456a1e%7C0%7C0%7C637434120784075979%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1tfpDmc%2BtRk6Z%2FuGOHnzTYd0ThkvvEL7Lpd6hcsL0yE%3D&reserved=0 / @pberinghttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpbering&data=04%7C01%7Cjean-francois.larente%40sitecore.com%7C5b38beceb4cc454a77ee08d89ef4a017%7C91700184c3144dc9bb7ea411df456a1e%7C0%7C0%7C637434120784075979%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mmKhzJB8zhRIhx%2BLI9qafjDcFW7eLHLjKHoZv0pMWI0%3D&reserved=0 just want to clarify that Remote file share is the equivalent of Azure File Share. I can help testing this next week if this is still required.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSitecore%2Fdocker-images%2Fpull%2F380%23issuecomment-743919135&data=04%7C01%7Cjean-francois.larente%40sitecore.com%7C5b38beceb4cc454a77ee08d89ef4a017%7C91700184c3144dc9bb7ea411df456a1e%7C0%7C0%7C637434120784085972%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=uS9hw%2FKNbuyY0j2WTamfQGvB54I%2B0VbIS8V7porfwaY%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABM4WBGZDKBGHCCT6CD6NQLSUP3GXANCNFSM4SVAT7FQ&data=04%7C01%7Cjean-francois.larente%40sitecore.com%7C5b38beceb4cc454a77ee08d89ef4a017%7C91700184c3144dc9bb7ea411df456a1e%7C0%7C0%7C637434120784085972%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=QITPZHvjKKiu5cUtL59jt8IimZH8Zf5UP%2B64HugDddQ%3D&reserved=0.
This message and its attachments are for the designated recipient only and may contain proprietary or otherwise confidential information. If you have received this message in error, please notify the sender immediately and delete the original. Any other sharing, copying or use of this message by you is strictly prohibited.