Sitecore-Instance-Manager icon indicating copy to clipboard operation
Sitecore-Instance-Manager copied to clipboard

added support for MSSQL default intances with windows authentication

Open lennartfranke opened this issue 9 years ago • 2 comments

Removed the "IntegratedSecurity = false" property, so Integrated Secutiy will not be disabled on a new instance when using connection strings like 'Data Source=.;Integrated Security=True'.

Fixed also an issue on non-english windows version where the 'IIS Check' does not work.

lennartfranke avatar Jan 08 '16 16:01 lennartfranke

Generally IntegratedSecurity = false was added as a workaround for the issue when importing/exporting solutions between systems where on the one side IntegratedSecurity is used and on the other one is not. I cannot accept this pull request without proper testing so lets postpone it a little bit.

AlenPelin avatar Jan 11 '16 00:01 AlenPelin

I should have split this into two separate pull requests but i saw you already implemented the fix for non-English locales with 1248c5ab4c0caa8907ac6ae5640afd3393ef5c1a.

Regarding the IntegratedSecurity: You are right, importing/exporting could be a problem, I don't had that in mind when creating the pull request. The import pipeline seem to have it's own processor for updating the ConnectionStrings with SIM.Pipelines.Import.UpdateConnectionStrings which also using IntegratedSecurity = false. I am not sure if it would be good when install and import would behave differently.

lennartfranke avatar Jan 11 '16 10:01 lennartfranke