dts-generator icon indicating copy to clipboard operation
dts-generator copied to clipboard

Published 20 hours ago • verified publisher icon SitePen

Add glob for issue #26

Open cybrown opened this issue 9 years ago • 8 comments

Add glob for files option, issue #26

cybrown avatar Aug 11 '15 11:08 cybrown

@cybrown we require CLAs for any contributions as part of the Dojo Foundation. I was unable to find a CLA based on your GitHub username. Could you please take a moment to file a CLA or let me know what username or e-mail address you used?

kitsonk avatar Sep 03 '15 12:09 kitsonk

This PR will be merged if I accept the CLA ?

cybrown avatar Sep 03 '15 12:09 cybrown

I haven't looked at it in detail, but it seems logical to me, so I will try to land it.

kitsonk avatar Sep 03 '15 13:09 kitsonk

I've signed the CLA, with my gmail: cy.brown59

cybrown avatar Sep 03 '15 15:09 cybrown

Cy Brown submitted a CLA on 2015-09-03 13:44:25.

kitsonk avatar Sep 04 '15 08:09 kitsonk

@cybrown sorry for taking so long to have a look at this... Would ultimately reading the tsconfig.json work for solving this (assuming it supports properly the globs property available in tsconfig.json)?

kitsonk avatar Sep 18 '15 13:09 kitsonk

I don't think that reading the tsconfig.json would be a good idea because I think that in most workflows, the generated .d.ts files are outputed in another directory, leaving the source directory clean.

cybrown avatar Sep 29 '15 15:09 cybrown

Pushing out to 2.2.0 as there are still changes to review.

dylans avatar Jan 30 '17 15:01 dylans