dgrid icon indicating copy to clipboard operation
dgrid copied to clipboard

Advance Row Selection - Extension

Open harpreetkhalsagtbit opened this issue 10 years ago • 5 comments

A dGrid extension for performing actions like Select All/Inverse/None Added dijit widget - Button at the top of grid's Header in three columns using same classes and tags as normal grid columns do. Added selectInverse() to Selection.js Also fixed one bug when tested with Column Resizer extension. Compatible with other extensions.

dgrid

harpreetkhalsagtbit avatar Feb 02 '14 14:02 harpreetkhalsagtbit

We really need this extension. Requesting any committers to review and give feedback. Our Dojo CLAs are signed. @SitePenKenFranqueiro

gaurav21r avatar Feb 13 '14 07:02 gaurav21r

Guys any updates on this? @dylans can you help out here??

gaurav21r avatar Apr 30 '14 08:04 gaurav21r

Its an extension and a useful feature for many many use cases. Since its an extension, it'll only load on demand to those who want it so no need to worry about bloat.

Also, I have been quite active in the forums irc and github. This will only be one of the many many PRs my company will make. We are working on a super huge platform using dojo and we make pay he almost on an everyday basis!!!!

I would request the dojo / site pen team to at least tell us why this isn't getting merged so we can learn and correct in future.

gaurav21r avatar Apr 30 '14 08:04 gaurav21r

*we make patches on an everyday basis.

gaurav21r avatar Apr 30 '14 08:04 gaurav21r

Hi @gaurav21r I think at a minimum the UI should be decoupled from the capabilities of this proposed extension. That way someone could bind the capabilities from an alternative UI than what has been proposed here.

As far as when this might get formally reviewed, keep in mind that the review and merging of each feature requires time and effort, and also means that we will maintain it going forward. Realistically, we've been heads down on getting 0.4's features ready and have a bit of a backlog, so we probably won't get a chance to review and include this prior to then.

I don't want to discourage you. We definitely appreciate your involvement and contribution efforts to date, we just only have so many hours in a day and have a long list of things we're trying to get finished!

dylans avatar Jun 28 '14 07:06 dylans