ForgifiedFabricAPI icon indicating copy to clipboard operation
ForgifiedFabricAPI copied to clipboard
verified publisher icon Sinytra

`VanillaModelEncoder#emitItemQuads` does not respect Forge/NeoForge model extensions

Open PepperCode1 opened this issue 11 months ago • 3 comments

NeoForge patches the ItemRenderer to respect IBakedModelExtension#getRenderPasses(ItemStack, boolean) and IBakedModelExtension#getRenderTypes(ItemStack, boolean): https://github.com/neoforged/NeoForge/blob/1.21.1/patches/net/minecraft/client/renderer/entity/ItemRenderer.java.patch#L26-L27.

Neither of these methods are ever called in either Forgified FRAPI or Forgified Indigo, which leads to severe issues like crashes and missing visuals. Calling them in VanillaModelEncoder#emitItemQuads would be the best solution, but would need additional work as FRAPI does not accept RenderTypes directly; this method would need to be moved to Forgified Indigo so it can provide the RenderTypes directly. Inspection of quads with a non-standard RenderType could result in BlendMode.DEFAULT.

PepperCode1 avatar Jan 05 '25 21:01 PepperCode1

Verbal upvote. tried Paladins furniture mod with this

JuddJohnsonIV avatar Sep 28 '25 03:09 JuddJohnsonIV

bump

Protnore avatar Oct 05 '25 15:10 Protnore

How we could help here? @Su5eD paladins mod is really nice furniture mod, but with connector it does not work

suerion avatar Nov 21 '25 21:11 suerion