ForgifiedFabricAPI icon indicating copy to clipboard operation
ForgifiedFabricAPI copied to clipboard

Issue with Forge Item Capabilities

Open furtabs opened this issue 1 year ago • 7 comments

When playing with any fabric mod in 1.20.1 and 1.21 Forge item capabilities are broken.

This issue is related to #121 and https://github.com/Sinytra/Connector/issues/1441. except that i opened it in the wrong place.

Looking at issue https://github.com/Sinytra/Connector/issues/1441 i was later informed this is a fabric api forgified bug and not a Connector issue.

I have later tested with multiple mods as such below and have seen item pipes do not connect to any tile entity if the pipe mod is from a forge mod. Using certain mods that extend vanilla items such as hoppers work fine but anything that is custom seems to break. Using LaserIO to force a connection pulls the cards out of the laserio node which makes me think its trying to pull the IInventory wrong.

I am going to look into this on my own time and try to submit a pull request.

image

image

Sorry if i was overly hostile, i was just kinda salty from the automated like responce of

As our LTS support target, 1.20.1 now only receives critical fixes related to Connector bugs. Please upgrade to the latest version for mod compatibility support.

when this bug seems to happen with many mods and would consider this critical because its inheritely an issue with how Forge Item Capabilites work and not a connector issue in general.

### Tasks

furtabs avatar Sep 30 '24 17:09 furtabs

Once again im sorry i was overly hostile, i just really would like to see this issue fixed, or atleast give me some pointers to submit a proper pull request.

furtabs avatar Sep 30 '24 17:09 furtabs

I have identified that the issue is probably tied to the Fabric-transfer-API, going to look deeper into this myself

furtabs avatar Sep 30 '24 17:09 furtabs

~~This commit seemed to of broke it https://modrinth.com/mod/forgified-fabric-api/version/0.89.0+1.9.24+1.20.1

4c6d1bcd56250f4c0af9d3b273e5a1f338591405~~

I have since retracted this statement. Still trying to find the broken commit.

furtabs avatar Sep 30 '24 17:09 furtabs

Yeah the pipes connect fine in 0.89.0+1.9.23 image

furtabs avatar Sep 30 '24 18:09 furtabs

This is the broken commit b00938ec12cc6caa62752e29748f6ce0163a996f.

Going to submit a PR to revert it. I do think that would be easiest solution.

furtabs avatar Sep 30 '24 18:09 furtabs

I have since confirmed this is also broken in 1.21.

image

furtabs avatar Sep 30 '24 20:09 furtabs

Apologies if this is necroposting, but is there any chance that this will be fixed in the future? I had to revert the fix responsible for this issue for my own modpack to be playable, since all of the pipes were completely broken.

MasterBroNetwork avatar Oct 16 '25 05:10 MasterBroNetwork