ConnectorExtras icon indicating copy to clipboard operation
ConnectorExtras copied to clipboard

Valkyrien Skies 2 has problem with Connector Extras

Open Corn-on-the-Orb opened this issue 1 year ago • 36 comments

Describe the bug

I tried to download VS2 into a modpack using connector, but always crashes in startup with something to do with 'reach_entity_attributes' mixins

Steps to reproduce

  1. Download Better MC
  2. Add VS2 and any dependancies
  3. disable ryoamic lights
  4. attempt to launch game ...

Logs

https://mclo.gs/5T0Pw6e

Additional context

No response

Corn-on-the-Orb avatar Apr 01 '24 00:04 Corn-on-the-Orb

Same here, https://mclo.gs/laogcFi I tried with only libs and optimization mods, because It's really hard to find THE mod that crash the game

Groupix05 avatar Apr 01 '24 19:04 Groupix05

https://pastebin.com/7TJCS8rq

Here is a log for a crash with 165 mods installed. It seems that the crash will only happen if there are 165 or more enabled. Why this is the case, I have no clue.

Billnotic avatar Apr 01 '24 21:04 Billnotic

Same problem here : https://pastebin.com/AvUxkYip

Disabling Valkyrian Skies 2 make the game launch

DaftHunk avatar Apr 03 '24 13:04 DaftHunk

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

zxy19 avatar Apr 08 '24 13:04 zxy19

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Corn-on-the-Orb avatar Apr 08 '24 14:04 Corn-on-the-Orb

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

zxy19 avatar Apr 08 '24 14:04 zxy19

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

Corn-on-the-Orb avatar Apr 08 '24 14:04 Corn-on-the-Orb

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

I'm not modifying the release jar file but building a new one from source code. If you don't wanna do so, you can try this file I build myself. ConnectorExtras-1.10.0+1.20.1+dev-g9a9680e.zip Just simply removed supply for "Reach Entity Attributes" which currently incompat with vs2.

zxy19 avatar Apr 08 '24 14:04 zxy19

ahhh i see what you mean now thanks a lot for the help, ive downloaded and made the change to the source code but not sure how to do the final build step you mentioned?

Corn-on-the-Orb avatar Apr 08 '24 14:04 Corn-on-the-Orb

Refere

I'm not a skilled java developer and cannot help you a lot. You can refer to forge document/gradle document to learn more.

zxy19 avatar Apr 08 '24 14:04 zxy19

removing the module didnt seem to do anything for me but make connector stop working with it, unless ive done it wrong... so ive yet to find a solution to this problem aside rom removing the mods entirely.

Corn-on-the-Orb avatar Apr 09 '24 21:04 Corn-on-the-Orb

Posting a link from the discord thread on the same issue here to bridge some information https://discord.com/channels/1141048834177388746/1222663653233262764 Is there any verifiable way to easily find what mods depend on reach-entity-attributes?

Liamgrayskull avatar Apr 14 '24 17:04 Liamgrayskull

Posting a link from the discord thread on the same issue here to bridge some information https://discord.com/channels/1141048834177388746/1222663653233262764 Is there any verifiable way to easily find what mods depend on reach-entity-attributes?

which server is that from?

Corn-on-the-Orb avatar Apr 16 '24 00:04 Corn-on-the-Orb

which server is that from?

Sinytra server https://discord.com/invite/mamk7z3TKZ

Groupix05 avatar Apr 16 '24 00:04 Groupix05

strange doesnt happen for me, although i dont disable ryoamic lights

awesomebossdj7 avatar Jun 23 '24 20:06 awesomebossdj7

Rebuild is not required, you can remove META-INF/jarjar/reach-entity-attributes-2.4.0.jar and remove line three to line thirteen in META-INF/jarjar/metadata.json in release jar file.

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

I'm not modifying the release jar file but building a new one from source code. If you don't wanna do so, you can try this file I build myself. ConnectorExtras-1.10.0+1.20.1+dev-g9a9680e.zip Just simply removed supply for "Reach Entity Attributes" which currently incompat with vs2.

colinxu2020 avatar Jul 20 '24 12:07 colinxu2020

Will this be fixed? The band aid fix does not do it for me as certain mods I am using rely on "reach-entity-attributes" from ConnectorExtras.

nikoraasu avatar Oct 17 '24 21:10 nikoraasu

This crash will be fixed in a newer version of Valkyrien Skies, before this year I think. Check their announcement on their discord.

Groupix05 avatar Oct 17 '24 21:10 Groupix05

I have no idea how reliable this is, but I was able to get it working by adding a false dependency to VS, to force VS to load before REA.

If you want to try this, it can be done by opening up the VS jar (using 7zip or winrar) and adding the following to the end of the mods.toml file

[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

tlitookilakin avatar Nov 01 '24 18:11 tlitookilakin

I had the same issue when adding Valkyrien Skies to the SteamPunk modpack (who uses ConnectorExtra for the Eldritch mod)

[[dependencies.valkyrienskies]] modId = "reach-entity-attributes" mandatory = false ordering = "BEFORE"

Doesn't work for me.

But, remove "reach-entity-attributes-2.4.0.jar" in META-INF/jarjar/metadata.json works. I don't know what effect it will have on the game...

gkr0013 avatar Nov 29 '24 18:11 gkr0013

I'm not able to remove REA as I have mods that rely on it.

tlitookilakin avatar Nov 29 '24 20:11 tlitookilakin

It works for me, thanks.

Versions

Module Version
Minecraft 1.20.1
Forge 47.3.5
Sinytra Connector 1.0.0-beta.46
Connector Extras 1.11.2+1.20.1
Valkyrien Skies 2.3.0-beta.5

Rebuild is not required, you can remove META-INF/jarjar/reach-entity-attributes-2.4.0.jar and remove line three to line thirteen in META-INF/jarjar/metadata.json in release jar file.

The problem is caused by module "reach-entity-attributes", I just removed the module and rebuild the jar then it works well.

where did you find the module in the jar file and how did you go about doing that?

Just download the source code and open "build.gradle.kts", then remove line below:

includeProject("reach-entity-attributes")

then execute gradle task "Jar" on project ConnectorExtra and get jar in build/lib.

Im using winrar to edit files and stuff and I cant seem to find "build.gradle.kts" anywhere, what software are you using to edit the jar with?

I'm not modifying the release jar file but building a new one from source code. If you don't wanna do so, you can try this file I build myself. ConnectorExtras-1.10.0+1.20.1+dev-g9a9680e.zip Just simply removed supply for "Reach Entity Attributes" which currently incompat with vs2.

TowardtheStars avatar Nov 30 '24 11:11 TowardtheStars

So, in the last two days I have found two working solutions for those who have mods that depend on REA (In my particular case Spectrum):

  1. Following the advice above, I added to the end of the META-INF/mods.toml file:
[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

After that, in the jar of the REA-dependent mod, I replaced the file META-INF/jars/reach-entity-attributes-2.4.0.jar with version 2.5.0 (found here). At this stage the game starts, but after the first load subsequent attempts will still crash, to prevent this it is necessary to clean mods/.connector every time.

Doesn't sound too reliable, does it? So here is the second solution, which definitely works:

  1. Clone the valkyrien skies repository, specifically the fix/2.3.0-beta.5-with-fixes branch. Replace the code as in this commit. And run the gradlew build. To be honest, I left the first method in case there are people who, like me recently, couldn't rebuild the mod themselves for various reasons.

Alenigma avatar Jan 08 '25 07:01 Alenigma

So, in the last two days I have found two working solutions for those who have mods that depend on REA (In my particular case Spectrum):

  1. Following the advice above, I added to the end of the META-INF/mods.toml file:
[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

After that, in the jar of the REA-dependent mod, I replaced the file META-INF/jars/reach-entity-attributes-2.4.0.jar with version 2.5.0 (found here). At this stage the game starts, but after the first load subsequent attempts will still crash, to prevent this it is necessary to clean mods/.connector every time.

Doesn't sound too reliable, does it? So here is the second solution, which definitely works:

  1. Clone the valkyrien skies repository, specifically the fix/2.3.0-beta.5-with-fixes branch. Replace the code as in this commit. And run the gradlew build. To be honest, I left the first method in case there are people who, like me recently, couldn't rebuild the mod themselves for various reasons.

I reckon the first method is the only viable solution for getting Spectrum working at the moment?

SmokePuddingEveryday avatar Jan 12 '25 08:01 SmokePuddingEveryday

I reckon the first method is the only viable solution for getting Spectrum working at the moment?

Well, no, both solutions are working

Alenigma avatar Jan 12 '25 09:01 Alenigma

So, in the last two days I have found two working solutions for those who have mods that depend on REA (In my particular case Spectrum):

1. Following the advice above, I added to the end of the META-INF/mods.toml file:
[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

After that, in the jar of the REA-dependent mod, I replaced the file META-INF/jars/reach-entity-attributes-2.4.0.jar with version 2.5.0 (found here). At this stage the game starts, but after the first load subsequent attempts will still crash, to prevent this it is necessary to clean mods/.connector every time.

Doesn't sound too reliable, does it? So here is the second solution, which definitely works:

2. Clone the valkyrien skies repository, specifically the fix/2.3.0-beta.5-with-fixes branch. Replace the code as in this [commit](https://github.com/ValkyrienSkies/Valkyrien-Skies-2/commit/500230d35ac3be3ded81b764926a672a3aa0da63). And run the gradlew build.
   To be honest, I left the first method in case there are people who, like me recently, couldn't rebuild the mod themselves for various reasons.

I am unable to get the mod to build with that commit its either builds successfully but the mod does not load in game, or it fails to compile forge:java can anyone help me out with this.

I am running on linux btw

Prodis252 avatar Jan 13 '25 05:01 Prodis252

So, in the last two days I have found two working solutions for those who have mods that depend on REA (In my particular case Spectrum):

  1. Following the advice above, I added to the end of the META-INF/mods.toml file:
[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

After that, in the jar of the REA-dependent mod, I replaced the file META-INF/jars/reach-entity-attributes-2.4.0.jar with version 2.5.0 (found here). At this stage the game starts, but after the first load subsequent attempts will still crash, to prevent this it is necessary to clean mods/.connector every time.

Doesn't sound too reliable, does it? So here is the second solution, which definitely works:

  1. Clone the valkyrien skies repository, specifically the fix/2.3.0-beta.5-with-fixes branch. Replace the code as in this commit. And run the gradlew build. To be honest, I left the first method in case there are people who, like me recently, couldn't rebuild the mod themselves for various reasons.

EDIT: nevermind my comment, I just had to look in the forge folder, not the main one. Thank you so much man! It actually works now

~~would you be able to help a bit? i cloned the repo you indicated, but trying to build gradle produces empty jar file, only with an empty manifest inside, the jar is less than 1kb~~

~~this happens even with an unchanged/untouched repo~~

neonishere avatar Jan 14 '25 14:01 neonishere

So, in the last two days I have found two working solutions for those who have mods that depend on REA (In my particular case Spectrum):

  1. Following the advice above, I added to the end of the META-INF/mods.toml file:
[[dependencies.valkyrienskies]]
modId = "reach-entity-attributes"
mandatory = false
ordering = "BEFORE"

After that, in the jar of the REA-dependent mod, I replaced the file META-INF/jars/reach-entity-attributes-2.4.0.jar with version 2.5.0 (found here). At this stage the game starts, but after the first load subsequent attempts will still crash, to prevent this it is necessary to clean mods/.connector every time. Doesn't sound too reliable, does it? So here is the second solution, which definitely works:

  1. Clone the valkyrien skies repository, specifically the fix/2.3.0-beta.5-with-fixes branch. Replace the code as in this commit. And run the gradlew build. To be honest, I left the first method in case there are people who, like me recently, couldn't rebuild the mod themselves for various reasons.

EDIT: nevermind my comment, I just had to look in the forge folder, not the main one. Thank you so much man! It actually works now

would you be able to help a bit? i cloned the repo you indicated, but trying to build gradle produces empty jar file, only with an empty manifest inside, the jar is less than 1kb

this happens even with an unchanged/untouched repo

im having the same issue withe the 1kb file tbh im too dumb to understand why but ig ill keep trying since i aint rich enough to pay 4 dollars for the actual fix made by the devs on their kofi

B14nk2 avatar Jan 28 '25 00:01 B14nk2

im having the same issue withe the 1kb file tbh im too dumb to understand why but ig ill keep trying since i aint rich enough to pay 4 dollars for the actual fix made by the devs on their kofi

You need to check forge/build/libs, not just build/libs

Alenigma avatar Jan 28 '25 04:01 Alenigma

can someone send me a premade build? i am not able to do one

ALEILGOD avatar Feb 20 '25 17:02 ALEILGOD