Connector icon indicating copy to clipboard operation
Connector copied to clipboard

Connector does not check the size of BEs loaded by Fabric mods, which breaks NeoForge culling.

Open Lolothepro opened this issue 1 year ago • 2 comments

Mod Name

Oritech

Mod Homepage

https://modrinth.com/mod/oritech

Minecraft version

1.21.1

Describe the bug

Some Oritech machines are not rendered in certain cases

Steps to reproduce

  1. Assemble an machine from the "Oritech" mod
  2. Use the command "/neoforge debug_blockentity_renderbounds true".
  3. See that culling is incorrect

Logs

https://mclo.gs/GMbh6fK

Additional context

No response

Lolothepro avatar Aug 08 '24 13:08 Lolothepro

Workaround: use Sodium

Lolothepro avatar Aug 17 '24 18:08 Lolothepro

A simple & more appropriate fix (as opposed to using a mod which has many other side effects, and simply ignores Neo's BE culling feature) is for Connector to automatically inject a getRenderBoundingBox method that returns AABB.INFINITE on any BlockEntityRenderer implementation within a Fabric mod. I believe this should be possible to do, as Connector already transforms the whole mod JAR, but I couldn't find the best location to add such a transformer myself.

embeddedt avatar Aug 17 '24 20:08 embeddedt